[2939] in BarnOwl Developers
[barnowl/barnowl] 765907: Don't precompute UTF-8 encodings of format charact...
daemon@ATHENA.MIT.EDU (noreply@github.com)
Sat Feb 26 00:59:49 2011
Date: Fri, 25 Feb 2011 21:59:47 -0800
To: barnowl-dev@mit.edu
From: noreply@github.com
Branch: refs/heads/master
Home: https://github.com/barnowl/barnowl
Commit: 765907946990deb3974af5b424314022ebdf86cc
https://github.com/barnowl/barnowl/commit/765907946990deb3974af5b424314022ebdf86cc
Author: David Benjamin <davidben@mit.edu>
Date: 2011-02-25 (Fri, 25 Feb 2011)
Changed paths:
M fmtext.c
M owl.h
Log Message:
-----------
Don't precompute UTF-8 encodings of format characters
GString can append gunichar just fine.
Commit: 237d02c0b7dc9e5a2f942f7dbcad63b75830350b
https://github.com/barnowl/barnowl/commit/237d02c0b7dc9e5a2f942f7dbcad63b75830350b
Author: David Benjamin <davidben@mit.edu>
Date: 2011-02-25 (Fri, 25 Feb 2011)
Changed paths:
M fmtext.c
M message.c
M owl.h
M viewwin.c
Log Message:
-----------
Remove default_{attrs,fgcolor,bgcolor} from owl_fmtext
They didn't quite behave when appending two owl_fmtexts together; what
does it mean to append a string whose default color is red to one whose
default color is blue? (And then you set the default to green
afterwards...)
Now owl_fmtext is merely a unicode string with formatting characters.
Default attributes are instead a property of how you view the string and
are passed to owl_fmtext_curs_waddstr. Which unfortunately means it has
a lot of arguments. :-/
Commit: cb6c9e17f3e050c43f919d1b30b35c0ac5316c95
https://github.com/barnowl/barnowl/commit/cb6c9e17f3e050c43f919d1b30b35c0ac5316c95
Author: David Benjamin <davidben@mit.edu>
Date: 2011-02-25 (Fri, 25 Feb 2011)
Changed paths:
M fmtext.c
Log Message:
-----------
Apply default attributes after processing commands
Otherwise we reset the color after every clump of formatting characters,
whether it includes a color or not. (Though this never happens because
of how we generate fmtext.) Also, actually modify the current attr so
that default_attrs works with search.
(While I'm at it, simplify _owl_fmtext_append_fmtext a bit.)
