[2907] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

Re: Kill owl_{malloc,realloc,free,strdup,sprintf} wrappers

daemon@ATHENA.MIT.EDU (Karl Ramm)
Fri Feb 11 11:59:56 2011

From: Karl Ramm <kcr@1ts.org>
To: Anders Kaseorg <andersk@mit.edu>
Cc: barnowl-dev@mit.edu
Date: Fri, 11 Feb 2011 11:59:53 -0500
In-Reply-To: <alpine.DEB.2.02.1102110408300.22897@dr-wily.mit.edu> (Anders
	Kaseorg's message of "Fri, 11 Feb 2011 04:12:28 -0500 (EST)")

Looks fine to me, although I sort of wish the opportunity had been taken to
add whitespace in places for readability.

Reviewed-By: Karl Ramm <kcr@mit.edu>

kcr
Anders Kaseorg <andersk@MIT.EDU> writes:

> (Note that the owl_text_tr patch I sent in reply to davidben earlier 
> introduces another owl_free that should become a g_free in whichever 
> branch is merged later.)
>
> The following changes since commit 9518a859987b60867c3566157ad0a24358cd28fb:
>
>   owl_function_classinstfilt: Do not turn [ '"] into . (2011-02-11 01:22:31 -0500)
>
> are available in the git repository at:
>   git://andersk.mit.edu/barnowl.git g_new
>
> Anders Kaseorg (5):
>       Replace owl_malloc with g_new and g_new0.
>       Replace owl_realloc with g_renew.
>       Replace owl_free with g_free.
>       Replace owl_strdup with g_strdup.
>       Replace owl_sprintf with g_strdup_printf.
>
>  aim.c           |   41 +++++------
>  buddy.c         |    6 +-
>  buddylist.c     |    6 +-
>  cmd.c           |   54 +++++++-------
>  commands.c      |   50 +++++++-------
>  context.c       |    9 +--
>  dict.c          |   14 ++--
>  editwin.c       |   30 ++++----
>  errqueue.c      |    2 +-
>  filter.c        |   22 +++---
>  filterelement.c |   16 ++--
>  fmtext.c        |   46 ++++++------
>  functions.c     |  208 +++++++++++++++++++++++++++---------------------------
>  global.c        |   40 +++++-----
>  history.c       |    6 +-
>  keybinding.c    |   16 ++--
>  keymap.c        |   22 +++---
>  list.c          |    6 +-
>  logging.c       |   58 ++++++++--------
>  message.c       |   64 +++++++++---------
>  msgwin.c        |    6 +-
>  owl.c           |   14 ++--
>  perlconfig.c    |   42 ++++++------
>  perlglue.xs     |   26 ++++----
>  popexec.c       |    8 +-
>  popwin.c        |    5 +-
>  regex.c         |    8 +-
>  select.c        |   16 ++--
>  style.c         |    8 +-
>  tester.c        |   24 +++---
>  text.c          |   34 +++++-----
>  util.c          |   95 ++++++++-----------------
>  variable.c      |   55 +++++++--------
>  view.c          |    4 +-
>  viewwin.c       |   14 ++--
>  zbuddylist.c    |   12 ++--
>  zephyr.c        |  198 ++++++++++++++++++++++++++--------------------------
>  zwrite.c        |   82 +++++++++++-----------
>  38 files changed, 662 insertions(+), 705 deletions(-)
>
> -- 8< --
> From 658d7ae3c220391678997d149b5c87340d3f9c2c Mon Sep 17 00:00:00 2001
> From: Anders Kaseorg <andersk@mit.edu>
> Date: Thu, 27 Aug 2009 00:51:45 -0400
> Subject: [PATCH 1/5] Replace owl_malloc with g_new and g_new0.
>
> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
> ---
>  aim.c        |    7 +++----
>  buddylist.c  |    6 +++---
>  cmd.c        |    4 ++--
>  commands.c   |    2 +-
>  context.c    |    3 +--
>  dict.c       |    2 +-
>  editwin.c    |   16 +++++++---------
>  filter.c     |    6 +++---
>  fmtext.c     |   18 +++++++++---------
>  functions.c  |   12 ++++++------
>  global.c     |    2 +-
>  keybinding.c |    2 +-
>  keymap.c     |    6 +++---
>  list.c       |    2 +-
>  logging.c    |    2 +-
>  message.c    |    2 +-
>  perlconfig.c |    2 +-
>  perlglue.xs  |    4 ++--
>  popexec.c    |    4 ++--
>  popwin.c     |    3 +--
>  select.c     |    6 +++---
>  text.c       |    8 ++++----
>  util.c       |   11 +++--------
>  variable.c   |   13 ++++++-------
>  viewwin.c    |    8 +++-----
>  zephyr.c     |   16 ++++++++--------
>  zwrite.c     |    2 +-
>  27 files changed, 78 insertions(+), 91 deletions(-)

home help back first fref pref prev next nref lref last post