[2898] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] 3f8251: Rewrite aimwrite

daemon@ATHENA.MIT.EDU (noreply@github.com)
Thu Feb 10 21:11:48 2011

Date: Thu, 10 Feb 2011 18:11:46 -0800
To: barnowl-dev@mit.edu
From: noreply@github.com

Branch: refs/heads/master
Home:   https://github.com/barnowl/barnowl

Commit: 3f82515ab61951233c6e4408b28b00de742a66b8
    https://github.com/barnowl/barnowl/commit/3f82515ab61951233c6e4408b28b00de742a66b8
Author: David Benjamin <davidben@mit.edu>
Date:   2011-02-10 (Thu, 10 Feb 2011)

Changed paths:
  M commands.c
  M functions.c

Log Message:
-----------
Rewrite aimwrite

This now makes more gratuitous use of glib and should, as a bonus, be
more sensible. In particular, we now consistently handle multi-word
recipients with and without -m. Also avoid duplicating sending code.


Commit: edd0be704c8df4198dab90ca1633cfa8be9c633f
    https://github.com/barnowl/barnowl/commit/edd0be704c8df4198dab90ca1633cfa8be9c633f
Author: David Benjamin <davidben@mit.edu>
Date:   2011-02-10 (Thu, 10 Feb 2011)

Changed paths:
  M perl/lib/BarnOwl/Message/Zephyr.pm

Log Message:
-----------
Only handle CCs in messages sent directly to you.

A zephyr with a CC line received on @SOME-REALM would still handle the
CC logic in replycmd. This oddity could possibly be retrofited to allow
@SOME-REALM to participate in CC'd messages, but that would require us
to handle CC lines on messages received on *. In the meantime, let's not
leave a half-baked not-feature.

Also refactor the block slightly. The original formulation is confusing;
it means to condition on the recipient of the message we reply to, but
actually checks $to, the recipient we use in the reply. It just happens
that in one case, the two are equal. The original code would assume that
case and then change its mind if it was wrong.



home help back first fref pref prev next nref lref last post