[2891] in BarnOwl Developers
Re: [PATCH] Move glib libraries from LDFLAGS to LIBS
daemon@ATHENA.MIT.EDU (David A Benjamin)
Mon Feb 7 09:38:01 2011
Date: Mon, 7 Feb 2011 09:37:57 -0500 (EST)
From: David A Benjamin <davidben@MIT.EDU>
To: Anders Kaseorg <andersk@mit.edu>
cc: barnowl-dev@mit.edu
In-Reply-To: <alpine.DEB.2.02.1102062335400.25040@dr-wily.mit.edu>
LGTM, assuming this does fix the errors on wheezy/natty.
David
On Sun, 6 Feb 2011, Anders Kaseorg wrote:
> This fixes linker errors on wheezy and natty:
> http://wiki.debian.org/ToolChain/DSOLinking
>
> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
> ---
> configure.ac | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 3e79802..6fbb59c 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -102,7 +102,7 @@ else
> XSUBPPFLAGS=""
> fi
>
> -dnl Add LDFLAGS for embedded perl
> +dnl Add LIBS for embedded perl
> FOO=`perl -MExtUtils::Embed -e ldopts`
> AC_MSG_NOTICE([Adding perl LIBS ${FOO}])
> LIBS=${LIBS}\ ${FOO}
> @@ -113,13 +113,13 @@ AX_PROG_PERL_MODULES([Class::Accessor::Fast],,
> AX_PROG_PERL_MODULES([PAR],,
> [AC_MSG_WARN([PAR.pm not found. Loadable modules will be disabled.])])
>
> -dnl Add CFLAGS and LDFLAGS for glib-2.0
> +dnl Add CFLAGS and LIBS for glib-2.0
> PKG_CHECK_MODULES(GLIB,[glib-2.0 gobject-2.0])
>
> AC_MSG_NOTICE([Adding glib-2.0 CFLAGS ${GLIB_CFLAGS}])
> AM_CFLAGS="${GLIB_CFLAGS} ${AM_CFLAGS}"
> -AC_MSG_NOTICE([Adding glib-2.0 LDFLAGS ${GLIB_LIBS}])
> -AM_LDFLAGS="${GLIB_LIBS} ${AM_LDFLAGS}"
> +AC_MSG_NOTICE([Adding glib-2.0 LIBS ${GLIB_LIBS}])
> +LIBS="${GLIB_LIBS} ${LIBS}"
>
> if test "x${prefix}" = "xNONE"; then
> prefix="${ac_default_prefix}"
> @@ -144,7 +144,6 @@ dnl _XOPEN_SOURCE is defined.
> AM_CFLAGS="$AM_CFLAGS -D__EXTENSIONS__"
>
> AC_SUBST([AM_CFLAGS])
> -AC_SUBST([AM_LDFLAGS])
> AC_SUBST([LIBFAIM_CFLAGS])
>
> AC_SUBST(XSUBPPDIR)
> --
> 1.7.4
>
>
