[2878] in BarnOwl Developers
[barnowl/barnowl] b1ed3e: Refactor some common code in colorpair_mgr
daemon@ATHENA.MIT.EDU (noreply@github.com)
Fri Feb 4 18:00:47 2011
Date: Fri, 4 Feb 2011 15:00:45 -0800
To: barnowl-dev@mit.edu
From: noreply@github.com
Branch: refs/heads/release-1.7
Home: https://github.com/barnowl/barnowl
Commit: b1ed3e2176455bca57f4ecf26a0d22da137630ed
https://github.com/barnowl/barnowl/commit/b1ed3e2176455bca57f4ecf26a0d22da137630ed
Author: David Benjamin <davidben@mit.edu>
Date: 2011-02-04 (Fri, 04 Feb 2011)
Changed paths:
M fmtext.c
M mainwin.c
Log Message:
-----------
Refactor some common code in colorpair_mgr
Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
Commit: 22662d73924e0627aaeab749c82bf46f7af4a111
https://github.com/barnowl/barnowl/commit/22662d73924e0627aaeab749c82bf46f7af4a111
Author: David Benjamin <davidben@mit.edu>
Date: 2011-02-04 (Fri, 04 Feb 2011)
Changed paths:
M fmtext.c
M mainwin.c
M owl.c
M owl.h
Log Message:
-----------
Don't reset colorpairs in the middle of drawing
Resetting colorpairs while drawing the mainwin causes the existing
contents in a popwin to refer to invalid color pairs. We used to draw
the mainwin first and redraw the contents of each window from scratch.
Moving to libpanel in 1.6 changed this, so background colors
occasionally bled into your popwin.
This changes the colorpair logic to only trigger when we need to, and to
forcibly dirty every window if needed. NOTE: if we don't have enough
color-pairs to draw the current screen, this will draw everything twice.
But it will probably almost never happen.
Reported-by: Alex Dehnert <adehnert@mit.edu>
Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
