[2871] in BarnOwl Developers
More glib than your BarnOwl has room for
daemon@ATHENA.MIT.EDU (David A Benjamin)
Tue Jan 25 00:35:33 2011
Date: Tue, 25 Jan 2011 00:32:32 -0500 (EST)
From: David A Benjamin <davidben@MIT.EDU>
To: barnowl-dev@mit.edu
I should probably write a bunch more unit tests to cover all this code,
but anyway. Dealing with reallocs and string lengths is hard, and all
those +5s in the code made me sad. So let's go use all the stuff glib
gives us.
The following changes since commit e06f413cb21f9b1aa3a993e0028180c7ec614b24:
Stick the local realm onto the argument of viewuser if needed (2011-01-24 22:57:20 -0500)
are available in the git repository at:
git://github.com/davidben/barnowl.git more-glib
David Benjamin (12):
Use g_strjoinv in owl_global_set_startupargs
Use a GPtrArray to manage the growing list in owl_parseline
strndup is pretty awesome and doesn't involve adding 5
Be more accurate in allocating argument vector in owl_command_view
Don't stick random NULs when waddnstr exists
Replace owl_fmtext's buffer management with GString
No need to NULL-terminate argument vectors
Replace realloc logic in owl_zephyr_getsubs with GString
Use GString instead of allocating a giant buffer in owl_parseline
Use g_strjoinv in parsing zwrite lines
Use GString in owl_cmddict_execute_argv
Make owl_text_indent return a new string
cmd.c | 30 ++++------
commands.c | 3 +-
fmtext.c | 180 +++++++++++++++++++++++------------------------------------
functions.c | 3 -
global.c | 17 +-----
owl.c | 11 ++--
owl.h | 4 +-
style.c | 3 +-
tester.c | 2 +
text.c | 14 +++--
util.c | 45 ++++++---------
zephyr.c | 52 +++++------------
zwrite.c | 17 +-----
13 files changed, 137 insertions(+), 244 deletions(-)
