[2853] in BarnOwl Developers
Re: [PATCH] Fix up feature macros somewhat
daemon@ATHENA.MIT.EDU (Karl Ramm)
Tue Jan 4 16:27:17 2011
From: Karl Ramm <kcr@1ts.org>
To: Nelson Elhage <nelhage@nelhage.com>
Cc: David Benjamin <davidben@mit.edu>, barnowl-dev@mit.edu
Date: Tue, 04 Jan 2011 16:27:14 -0500
In-Reply-To: <AANLkTinXyvckFx4qGKC+odRbvJF9NOtbv3dmF02_pi0c@mail.gmail.com>
(Nelson Elhage's message of "Tue, 4 Jan 2011 14:49:18 -0500")
cattr_t or caddr_t?
Nelson Elhage <nelhage@nelhage.com> writes:
> sgtm, assuming you've build-tested everywhere
>
> On Tue, Jan 4, 2011 at 12:14 PM, David Benjamin <davidben@mit.edu> wrote:
>> Set _XOPEN_SOURCE to 500 to target a sufficiently new standard. Also
>> define _BSD_SOURCE because zephyr needs a BSD extension (caddr_t).
>> Apparently both of these bugs were masked on Debathena because Ubuntu's
>> perl defines _GNU_SOURCE which turns everything on.
>>
>> This also removes the need for __EXTENSIONS__ to get struct timeval on
>> Solaris. But we can't quite get rid of it yet because we use strcasecmp
>> and MAXHOSTNAMELEN.
>>
>> Reported-By: Alex Vandiver <alexmv@mit.edu>
>> ---
>> =C2=A0configure.ac | =C2=A0 =C2=A07 ++++---
>> =C2=A01 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 6a8e89f..d40e6e3 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -138,9 +138,10 @@ AM_CONDITIONAL([ENABLE_ZCRYPT], [test "$HAVE_DES_ST=
RING_TO_KEY" && dnl
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0test "$HAVE_DES_KEY_SCHED" =
&& dnl
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0test "$HAVE_DES_ECB_ENCRYPT=
"])
>>
>> -AM_CFLAGS=3D"$AM_CFLAGS -D_XOPEN_SOURCE"
>> -dnl __EXTENSIONS__ is needed for struct timeval on Solaris when
>> -dnl _XOPEN_SOURCE is defined.
>> +AM_CFLAGS=3D"$AM_CFLAGS -D_XOPEN_SOURCE=3D500"
>> +dnl Define _BSD_SOURCE because zephyr needs cattr_t.
>> +AM_CFLAGS=3D"$AM_CFLAGS -D_BSD_SOURCE"
>> +dnl Define __EXTENSIONS__ for strcasecmp on Solaris.
>> =C2=A0AM_CFLAGS=3D"$AM_CFLAGS -D__EXTENSIONS__"
>>
>> =C2=A0AC_SUBST([AM_CFLAGS])
>> --
>> 1.7.3.3.399.g06ddf
>>
>>
