[2851] in BarnOwl Developers
Re: Ticket #158 ./configure --without-zephyr && make fails with
daemon@ATHENA.MIT.EDU (Daniel M. Bergey)
Tue Jan 4 14:35:37 2011
Date: Tue, 4 Jan 2011 14:35:34 -0500
From: "Daniel M. Bergey" <bergey@MIT.EDU>
To: David A Benjamin <davidben@mit.edu>
Cc: Nelson Elhage <nelhage@nelhage.com>, barnowl-dev@mit.edu
In-Reply-To: <alpine.DEB.1.10.1101031452550.15170@dr-wily.mit.edu>
I thought there might be plans to use com_err in non-zephyr code. If not, the
ifdef seems cleaner.
bergey
On Mon, Jan 03, 2011 at 02:56:54PM -0500, David A Benjamin wrote:
> It looks like the only call is the one outside zephyr.c is
> owl_function_zwrite. I think owl_function_zwrite is never called without
> zephyr enabled. And if it were, the codepath should still never run
> because send_zephyr always returns 0 without zephyr built-in.
>
> We should possible refactor that code to move the error_message call
> elsewhere. Or I guess we may as well just wrap all of owl_function_zwrite
> with an ifdef.
>
> David
>
> On Mon, 3 Jan 2011, Nelson Elhage wrote:
>
>> Hm. It sounds like the bug is one of:
>>
>> - We require com_err at all if we're not using Zephyr.
>> - We use com_err even if config.h says we don't have it.
>>
>> Where does the error_message reference come from when building --without-zephyr?
>> Can we kill it or move it inside a Zephyr ifdef? That would be my inclination,
>> but if not, I'll take this patch.
>>
>> Also, if we really can't build without com_err, ./configure should probably bail
>> out in that case, instead of letting us get to the compilation/linker error.
>>
>> - Nelson
