[2846] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[barnowl/barnowl] d275eb: Replace atokenize with glib's g_strsplit_set

daemon@ATHENA.MIT.EDU (noreply@github.com)
Mon Jan 3 20:24:16 2011

Date: Mon, 3 Jan 2011 17:24:09 -0800
To: barnowl-dev@mit.edu
From: noreply@github.com

Branch: refs/heads/master
Home:   https://github.com/barnowl/barnowl

Commit: d275eb230e4d493acbb920b9bae25b692b199412
    https://github.com/barnowl/barnowl/commit/d275eb230e4d493acbb920b9bae25b692b199412
Author: David Benjamin <davidben@mit.edu>
Date:   2011-01-02 (Sun, 02 Jan 2011)

Changed paths:
  M commands.c
  M keybinding.c
  M util.c
  M variable.c

Log Message:
-----------
Replace atokenize with glib's g_strsplit_set

Glib's had g_strsplit_set since forever, and it does exactly the same
thing as atokenize, modulo needing a pesky NULL check. We may as well
use it.


Commit: 2bc6ad357ce0b84ad2c9d318202b8708a4c96378
    https://github.com/barnowl/barnowl/commit/2bc6ad357ce0b84ad2c9d318202b8708a4c96378
Author: David Benjamin <davidben@mit.edu>
Date:   2011-01-02 (Sun, 02 Jan 2011)

Changed paths:
  M tester.c
  M util.c

Log Message:
-----------
Add owl_quote_arg and owl_string_append_quoted_arg

Also add unit tests. We don't appear to have an equivalent of
BarnOwl::quote in C that actually works.


Commit: d222c44c7a6cab8cd6859100b0c4f22ea74d345a
    https://github.com/barnowl/barnowl/commit/d222c44c7a6cab8cd6859100b0c4f22ea74d345a
Author: David Benjamin <davidben@mit.edu>
Date:   2011-01-02 (Sun, 02 Jan 2011)

Changed paths:
  M filterelement.c
  M functions.c
  M global.c
  M text.c

Log Message:
-----------
Kill owl_getquoting and fix quoting bugs

That function is nonsense. Fix a number of quoting bugs relating to its
use (and lack thereof).

Also quote regex characters in CC narrows.


Commit: 719119de6c2aeaa0b75be7f6aac0cbaee43f36d8
    https://github.com/barnowl/barnowl/commit/719119de6c2aeaa0b75be7f6aac0cbaee43f36d8
Author: David Benjamin <davidben@mit.edu>
Date:   2011-01-03 (Mon, 03 Jan 2011)

Changed paths:
  M message.c
  M zwrite.c

Log Message:
-----------
Build reply commands from scratch on outgoing zwrites

We currently reuse the original zwrite line which is problematic when
the user passed -m. Instead regenerates the zwrite line from the
parsed owl_zwrite.

Repurpose the zwriteline attribute because anyone using the old
attribute probably has the same bug.



home help back first fref pref prev next nref lref last post