[2821] in BarnOwl Developers
[PATCH] Fix replying to outgoing messages with -m
daemon@ATHENA.MIT.EDU (David Benjamin)
Wed Dec 15 02:29:16 2010
From: David Benjamin <davidben@MIT.EDU>
To: barnowl-dev@mit.edu
Date: Wed, 15 Dec 2010 02:29:08 -0500
Do a zwrite somebody -m something and then reply to it. Umm, yeah. Oops.
This patch builds on top of the quoting patches I just pushed. The branch
itself is in my github at
git://github.com/davidben/barnowl.git reply-outgoing
(The quoting stuff is on branch quoting, I forgot to mention.)
For now, I've made it add a new attribute, replyline to hold the reply line.
Alternatively, we can just reuse the zwriteline attribute. This would result in
a somewhat backwards-incompatible change in that zwriteline is now "the
zwriteline to reply here" rather than "the zwriteline that created this
message", however anyone using that attribute likely had the same bug.
(I think I might actually prefer the somewhat backwards-incompatible version,
but it feels poor to call the reply command a "zwriteline".)
I've also made it preserve every option but -m for now. We maybe want to
consider ignoring some others? Opcode?
Thoughts?
This patch also conflicts with liudi's patch for #63 from a while ago. I'll
deal with the rebasing; it also provides a nice place to implement the
suggested option A.1. (Right now merging it would result in A.2, which seems a
little poor.)
David Benjamin (1):
Build reply commands from scratch on outgoing zwrites
message.c | 18 ++++++++++++++
perl/lib/BarnOwl/Message/Zephyr.pm | 2 +-
zwrite.c | 45 ++++++++++++++++++++++++++++++++++++
3 files changed, 64 insertions(+), 1 deletions(-)
--
1.7.3.3.399.g06ddf
