[2803] in BarnOwl Developers
[barnowl/barnowl] 5fca55: I/O errors on writing subscription file in :unsub ...
daemon@ATHENA.MIT.EDU (noreply@github.com)
Fri Nov 19 02:17:11 2010
Date: Thu, 18 Nov 2010 23:17:09 -0800
To: barnowl-dev@mit.edu
From: noreply@github.com
Branch: refs/heads/master
Home: https://github.com/barnowl/barnowl
Commit: 5fca55faa3051b261c981c98acb1323ff48cec10
https://github.com/barnowl/barnowl/commit/5fca55faa3051b261c981c98acb1323ff48cec10
Author: Jason Gross <jgross@MIT.EDU>
Date: 2010-11-18 (Thu, 18 Nov 2010)
Changed paths:
M util.c
M zephyr.c
Log Message:
-----------
I/O errors on writing subscription file in :unsub are no longer clobbered by "No subscription present in..."
owl_util_file_deleteline now returns -1 on error, and owl_zephyr_delsub
now checks linesdeleted == 0 before erroring with "No subscription
present in...".
Additionally, free(filename) corrected to owl_free(filename) in two
places.
Reviewed-By: Karl Ramm <kcr@1ts.org>
Commit: 950e2dac3c1ac939dde4d38764054386fa3bcf17
https://github.com/barnowl/barnowl/commit/950e2dac3c1ac939dde4d38764054386fa3bcf17
Author: Jason Gross <jgross@MIT.EDU>
Date: 2010-11-18 (Thu, 18 Nov 2010)
Changed paths:
M util.c
Log Message:
-----------
Fixed :unsub to make it work if ~/.zephyr.subs is a symlink (trac 133)
link() fails on AFS if the target is a symlink. Additionally, on
systems where link() succeeds, barnowl overwrites the symlink, instead
of the actual file. To fix this, I've changed owl_util_file_deleteline
to resolve symlinks on the passed file name first. The new (backup)
file is written in the resolved directory, not the directory where the
symlink itself is found.
A helper function, owl_util_recursive_resolve_link, is added to
recursivly resolve symlinks (if necessary).
Reviewed-By: Karl Ramm <kcr@1ts.org>
