[2732] in BarnOwl Developers
Re: Pile of random cleanup patches
daemon@ATHENA.MIT.EDU (David A Benjamin)
Sat Oct 30 22:32:52 2010
Date: Sat, 30 Oct 2010 22:32:48 -0400 (EDT)
From: David A Benjamin <davidben@MIT.EDU>
To: Anders Kaseorg <andersk@mit.edu>
cc: barnowl-dev@mit.edu
In-Reply-To: <alpine.DEB.2.00.1010282301560.3947@dr-wily.mit.edu>
This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
---1257051904-1209720646-1288492368=:15631
Content-Type: TEXT/PLAIN; charset=UTF-8; format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
One comment below. Rest of the code changes LGTM, but I don't know=20
anything about autotools. And one of the patches is mine, so I probably=20
can't really review it. :-) I guess your including it can count though. In=
=20
retrospect, it appears I forgot to put the variable declarations at the=20
top of the block, if we care.
Shrug. I trust you to know what you're doing as far as autotools goes.
David
On Thu, 28 Oct 2010, Anders Kaseorg wrote:
> Anders Kaseorg (12):
> Use AM_{CPP,C,LD}FLAGS instead of overriding {CPP,C,LD}FLAGS
> Silence some clang warnings for libfaim
> Don=E2=80=99t use AX_CFLAGS_STRICT_PROTOTYPES
> owl_function_zephyr_buddy_check: Remove unused variable zbl
> owl_perlconfig_hashref2message: Remove unused variable count
> owl_select_aim_hack: Remove redundant assignment of max_fd
> owl_zephyr_loadbarnowldefaultsub: Remove redundant assignment of ret
> zcrypt: Make strings const
It looks like ZWRITEOPTIONS.message tends to be malloc'd from=20
BuildArgString? There's certainly not much point in free'ing it, but=20
storing as const feels somewhat off? signature comes from optarg, so I=20
guess the const is correct there? I almost wonder if we want to strdup it=
=20
for consistency, but it all seems a little silly.
> owl_function_loopwrite_setup: Remove unused callback argument
> owl_text_expand_tabs: Make q const
> Only add missing Zephyr prototypes for the versions where they=E2=80=
=99re missing
> _owl_function_timer_append_fmtext: Cast time_t to int for sprintf("%=
d")
>
> David Benjamin (1):
> Avoid stripping parameters for function calls in window.c
>
> Makefile.am | 5 +-
> configure.ac | 27 ++++---
> functions.c | 6 +-
> m4/ax_cflags_strict_prototypes.m4 | 166 --------------------------------=
-----
> owl.h | 4 +-
> perlconfig.c | 4 +-
> select.c | 2 +-
> text.c | 4 +-
> window.c | 25 +++++-
> zcrypt.c | 6 +-
> zephyr.c | 1 -
> 11 files changed, 49 insertions(+), 201 deletions(-)
> delete mode 100644 m4/ax_cflags_strict_prototypes.m4
>
---1257051904-1209720646-1288492368=:15631--
