[2723] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[PATCH] Don't re-initialize lists in BarnOwl::all_keymaps

daemon@ATHENA.MIT.EDU (David Benjamin)
Sat Oct 23 15:57:16 2010

From: David Benjamin <davidben@MIT.EDU>
To: barnowl-dev@mit.edu
Date: Sat, 23 Oct 2010 15:55:54 -0400

owl_keyhandler_get_keymap_names eventually calls owl_list_create, so the
first initialization gets lost.
---
 perlglue.xs |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/perlglue.xs b/perlglue.xs
index 12877de..60e9eb8 100644
--- a/perlglue.xs
+++ b/perlglue.xs
@@ -387,7 +387,6 @@ all_keymaps()
 		const owl_keyhandler *kh;
 	CODE:
 	{
-		owl_list_create(&l);
 		kh = owl_global_get_keyhandler(&g);
 		owl_keyhandler_get_keymap_names(kh, &l);
 		RETVAL = owl_new_av(&l, (SV*(*)(const void*))owl_new_sv);
-- 
1.7.3.1.g716de


home help back first fref pref prev next nref lref last post