[2718] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

Re: [PATCH] When deleting a variable, clean-up strings

daemon@ATHENA.MIT.EDU (David A Benjamin)
Sat Oct 23 14:49:04 2010

Date: Sat, 23 Oct 2010 14:49:03 -0400 (EDT)
From: David A Benjamin <davidben@MIT.EDU>
To: barnowl-dev@mit.edu
In-Reply-To: <1287859425-5596-1-git-send-email-davidben@mit.edu>

Er, scratch this one for now. It looks like only perl-allocated variables 
strdup their names.

(Yes, I'm having fun with valgrind. How did you know?)

David

On Sat, 23 Oct 2010, David Benjamin wrote:

> ---
> variable.c |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/variable.c b/variable.c
> index 5380e62..b38a1cc 100644
> --- a/variable.c
> +++ b/variable.c
> @@ -641,6 +641,9 @@ void owl_variable_dict_namelist_cleanup(owl_list *l)
> void owl_variable_delete(owl_variable *v)
> {
>   if (v->delete_fn) v->delete_fn(v);
> +  owl_free(v->name);
> +  owl_free(v->summary);
> +  owl_free(v->description);
>   owl_free(v);
> }
>
> -- 
> 1.7.3.1.g716de
>
>

home help back first fref pref prev next nref lref last post