[2709] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[PATCH] Fix a few more memory leaks from short_zuser

daemon@ATHENA.MIT.EDU (David Benjamin)
Sat Oct 23 01:38:56 2010

From: David Benjamin <davidben@MIT.EDU>
To: barnowl-dev@mit.edu
Date: Sat, 23 Oct 2010 01:38:39 -0400

Also change a pointless owl_sprintf to owl_strdup.
---
 logging.c |    4 +++-
 zephyr.c  |    1 +
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/logging.c b/logging.c
index 8738ef7..90a0453 100644
--- a/logging.c
+++ b/logging.c
@@ -141,6 +141,7 @@ void owl_log_outgoing(const owl_message *m)
       snprintf(filename, MAXPATHLEN, "%s/%s", logpath, temp);
       owl_log_append(m, filename);
 
+      owl_free(temp);
       owl_free(cc->data);
       cc = g_list_delete_link(cc, cc);
     }
@@ -157,7 +158,7 @@ void owl_log_outgoing(const owl_message *m)
     owl_free(temp2);
     owl_free(temp);
   } else {
-    to = owl_sprintf("loopback");
+    to = owl_strdup("loopback");
   }
 
   snprintf(filename, MAXPATHLEN, "%s/%s", logpath, to);
@@ -334,6 +335,7 @@ void owl_log_incoming(const owl_message *m)
         owl_log_append(m, filename);
       }
 
+      owl_free(temp);
       owl_free(cc->data);
       cc = g_list_delete_link(cc, cc);
     }
diff --git a/zephyr.c b/zephyr.c
index 905fa76..790d627 100644
--- a/zephyr.c
+++ b/zephyr.c
@@ -951,6 +951,7 @@ char *owl_zephyr_zlocate(const char *user, int auth)
       result = p;
     }
   }
+  owl_free(myuser);
 
   return result;
 #else
-- 
1.7.3.1.g716de


home help back first fref pref prev next nref lref last post