[2687] in BarnOwl Developers
Re: [PATCH] Remove the DESTROY hook in MainLoopCompatHook
daemon@ATHENA.MIT.EDU (Nelson Elhage)
Wed Sep 29 18:49:17 2010
From: Nelson Elhage <nelhage@MIT.EDU>
To: David Benjamin <davidben@mit.edu>, barnowl-dev@mit.edu
In-Reply-To: <1285789789-9806-1-git-send-email-davidben@mit.edu>
Date: Wed, 29 Sep 2010 18:49:13 -0400
sgtm
On Wed, 29 Sep 2010 15:49:49 -0400, David Benjamin <davidben@MIT.EDU> wrote:
> It can't cause a timer leak and is causing spew in tests.
> ---
> perl/lib/BarnOwl/MainLoopCompatHook.pm | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/perl/lib/BarnOwl/MainLoopCompatHook.pm b/perl/lib/BarnOwl/MainLoopCompatHook.pm
> index 35cdb2f..8367a69 100644
> --- a/perl/lib/BarnOwl/MainLoopCompatHook.pm
> +++ b/perl/lib/BarnOwl/MainLoopCompatHook.pm
> @@ -36,11 +36,6 @@ sub clear {
> $self->{hook}->clear();
> }
>
> -sub DESTROY {
> - my $self = shift;
> - $self->clear();
> -}
> -
> sub _ensure_timer {
> my $self = shift;
> BarnOwl::debug("Enabling backwards-compatibility \"main loop\" hook");
> --
> 1.7.3.1.g716de
>
>
