[2665] in BarnOwl Developers
Re: [PATCH] add a random zsig function
daemon@ATHENA.MIT.EDU (Nelson Elhage)
Tue Sep 21 10:01:18 2010
From: Nelson Elhage <nelhage@MIT.EDU>
To: Kevin Riggle <kevinr@free-dissociation.com>,
Anders Kaseorg <andersk@mit.edu>
Cc: Zev Benjamin <zev@mit.edu>, barnowl-dev <barnowl-dev@mit.edu>
In-Reply-To: <1285043695-sup-7393@black-opal.free-dissociation.com>
Date: Tue, 21 Sep 2010 10:01:14 -0400
On Tue, 21 Sep 2010 00:38:19 -0400, Kevin Riggle <kevinr@free-dissociation.=
com> wrote:
> Excerpts from Anders Kaseorg's message of Tue Sep 21 00:19:37 -0400 2010:
> > On Mon, 20 Sep 2010, Zev Benjamin wrote:
> > But=20
> > actually he just traded one warning for another: =E2=80=98Use of uninit=
ialized=20
> > value within @lines in string=E2=80=99.
>=20
> Oh, these are warnings, not errors. That explains why I wasn't seeing th=
em.
> (Have we considered turning on 'use warnings' and 'use strict' in the Bar=
nOwl
> codebase? I bet that would be a bit of a nightmare, actually. :/)
I consider it a bug if strict and warnings aren't on in a compilation
unit, and they should be in BarnOwl.pm -- they're the first two lines of
the file.
I would expect warnings to show up in ":show errors", and transiently in
the message area.
> >=20
> > How about writing something more obvious to handle that case explicitly:
> > return '' if !@lines;
> >=20
> > (There seems to be something about this feature that encourages excessi=
ve=20
> > bikeshedding, for which I apologize.)
>=20
> Honestly, pointing out issues with my Perl is so far from the bikesheddin=
g I=20
> was worried about that I almost don't mind it at all. :-)
> >=20
> > > > + open my $file, '<', $zsigfile or die "File $zsigfile is=20
> > > > inaccessible or nonexistent.";
> >=20
> > Including $! in the message would tell the user which problem it is.
> >=20
> Updated patch has been sent.
>=20
> - Kevin
>=20
