[2641] in BarnOwl Developers
Re: [PATCH 0/3] Various shutdown cleanups
daemon@ATHENA.MIT.EDU (Nelson Elhage)
Sat Sep 18 15:03:16 2010
From: Nelson Elhage <nelhage@MIT.EDU>
To: David Benjamin <davidben@mit.edu>, barnowl-dev@mit.edu
In-Reply-To: <1284793231-20249-1-git-send-email-davidben@mit.edu>
Date: Sat, 18 Sep 2010 15:03:13 -0400
Looks good to me. I like the symmetry of the third for moving the
cleanup into the same place the setup happens.
Reviewed-by: Nelson Elhage <nelhage@mit.edu>
On Sat, 18 Sep 2010 03:00:28 -0400, David Benjamin <davidben@MIT.EDU> wrote:
> This cleans up the event loop code somewhat so that we can exit the select
> loop. In particular, this means that owl_function_quit actually returns to main
> and main is allowed to clean up.
>
> I'm not totally sure what should be moved to the bottom part of main (and
> subsequently pulled elsewhere). The last patch moves zephyr and ncurses on
> grounds of main being the one that sets them up, but really our startup code is
> a mess anyway. I suspect it'll eventually be all in a owl_global_cleanup or
> something.
>
> Anyway, I think the first two are clearly good. Third's probably reasonable
> too.
>
> David Benjamin (3):
> Move the error signal logging to a pre_select_action
> Move the event loop to owl_select as owl_select_run_loop
> Move zephyr and ncurses shutdown into main
>
> functions.c | 11 +----------
> owl.c | 39 +++++++++++++++++++++++----------------
> select.c | 14 ++++++++++++++
> 3 files changed, 38 insertions(+), 26 deletions(-)
>
> --
> 1.7.2.1.45.gb1c4
>
>
