[2635] in BarnOwl Developers

home help back first fref pref prev next nref lref last post

[PATCH 0/3] Various shutdown cleanups

daemon@ATHENA.MIT.EDU (David Benjamin)
Sat Sep 18 03:00:38 2010

From: David Benjamin <davidben@MIT.EDU>
To: barnowl-dev@mit.edu
Date: Sat, 18 Sep 2010 03:00:28 -0400

This cleans up the event loop code somewhat so that we can exit the select
loop. In particular, this means that owl_function_quit actually returns to main
and main is allowed to clean up.

I'm not totally sure what should be moved to the bottom part of main (and
subsequently pulled elsewhere). The last patch moves zephyr and ncurses on
grounds of main being the one that sets them up, but really our startup code is
a mess anyway. I suspect it'll eventually be all in a owl_global_cleanup or
something.

Anyway, I think the first two are clearly good. Third's probably reasonable
too.

David Benjamin (3):
  Move the error signal logging to a pre_select_action
  Move the event loop to owl_select as owl_select_run_loop
  Move zephyr and ncurses shutdown into main

 functions.c |   11 +----------
 owl.c       |   39 +++++++++++++++++++++++----------------
 select.c    |   14 ++++++++++++++
 3 files changed, 38 insertions(+), 26 deletions(-)

-- 
1.7.2.1.45.gb1c4


home help back first fref pref prev next nref lref last post