[2629] in BarnOwl Developers
Re: [PATCH] Remove _owl_panel_set_window
daemon@ATHENA.MIT.EDU (=?UTF-8?B?IkFsZWphbmRybyBSLiBTZWRl)
Tue Sep 14 17:13:40 2010
Date: Tue, 14 Sep 2010 17:13:36 -0400
From: =?UTF-8?B?IkFsZWphbmRybyBSLiBTZWRlw7FvIg==?= <asedeno@MIT.EDU>
To: David Benjamin <davidben@mit.edu>
CC: barnowl-dev@mit.edu
In-Reply-To: <1284497860-3694-1-git-send-email-davidben@mit.edu>
Yes, make the dead code go away.
Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
On 09/14/2010 04:57 PM, David Benjamin wrote:
> It hasn't been used since owl_window.
> ---
> global.c | 24 ------------------------
> 1 files changed, 0 insertions(+), 24 deletions(-)
>
> diff --git a/global.c b/global.c
> index e2887fc..cfe58cf 100644
> --- a/global.c
> +++ b/global.c
> @@ -149,30 +149,6 @@ void owl_global_complete_setup(owl_global *g)
> owl_cmddict_setup(&(g->cmds));
> }
>
> -/* If *pan does not exist, we create a new panel, otherwise we replace the
> - window in *pan with win.
> -
> - libpanel PANEL objects cannot exist without owner a valid window. This
> - maintains the invariant for _owl_global_setup_windows. */
> -void _owl_panel_set_window(PANEL **pan, WINDOW *win)
> -{
> - WINDOW *oldwin;
> -
> - if (win == NULL) {
> - owl_function_debugmsg("_owl_panel_set_window: passed NULL win (failed to allocate?)");
> - endwin();
> - exit(50);
> - }
> -
> - if (*pan) {
> - oldwin = panel_window(*pan);
> - replace_panel(*pan, win);
> - delwin(oldwin);
> - } else {
> - *pan = new_panel(win);
> - }
> -}
> -
> owl_context *owl_global_get_context(owl_global *g) {
> if (!g->context_stack)
> return NULL;
