[2573] in BarnOwl Developers
Re: [PATCH 3/4] _owl_fmtext_append_fmtext takes an inclusive range
daemon@ATHENA.MIT.EDU (David A Benjamin)
Mon Aug 2 23:36:11 2010
Date: Mon, 2 Aug 2010 23:36:08 -0400 (EDT)
From: David A Benjamin <davidben@MIT.EDU>
To: Nelson Elhage <nelhage@mit.edu>
cc: Anders Kaseorg <andersk@mit.edu>, barnowl-dev@mit.edu
In-Reply-To: <871vagqz35.fsf@mit.edu>
This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
---1257051904-919280001-1280806568=:2102
Content-Type: TEXT/PLAIN; charset=utf-8; format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
On Mon, 2 Aug 2010, Nelson Elhage wrote:
> Oh, I see you fix it later. Might as well clean that up.
Oh. Must have squashed the fix into the wrong commit.
David
> Otherwise, lgtm.
>
> - Nelson
>
> On Wed, 28 Jul 2010 00:52:08 -0400 (EDT), David A Benjamin <davidben@MIT.=
EDU> wrote:
>> Eh, it's not that hard. I've updated this patchset and expand-tabs on to=
p
>> of it.
>>
>> http://github.com/davidben/barnowl/commits/master
>> http://github.com/davidben/barnowl/commits/expand-tabs
>>
>> The test case commit now adds the tests for
>> owl_fmtext_truncate_{lines,cols} (the other callers of
>> _owl_fmtext_append_fmtext), the latter reordered from expand-tabs. And
>> then the next commit switching to a half-open range.
>>
>> David
>>
>> On Tue, 27 Jul 2010, Nelson Elhage wrote:
>>
>>> =3D=3Dandersk, but this is an improvement if it's too much of a pain to=
fix
>>> quickly (I haven't checked how many callers it has, but I can't imagine
>>> it being that bad).
>>>
>>> This whole series
>>> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
>>>
>>> On Sun, 25 Jul 2010 18:32:43 -0400 (EDT), Anders Kaseorg <andersk@MIT.E=
DU> wrote:
>>>> On Sun, 25 Jul 2010, David Benjamin wrote:
>>>>> - _owl_fmtext_append_fmtext(f, in, 0, in->textlen);
>>>>> + _owl_fmtext_append_fmtext(f, in, 0, in->textlen - 1);
>>>>
>>>> I=E2=80=99d rather fix this by changing _owl_fmtext_append_fmtext to t=
ake a
>>>> half-open range, like any sane function should.
>>>>
>>>> Anders
>>>>
>>>
>
---1257051904-919280001-1280806568=:2102--
