[2570] in BarnOwl Developers
Re: [PATCH] Correctly maintain the doubly linked list in owl_widnow
daemon@ATHENA.MIT.EDU (Nelson Elhage)
Mon Aug 2 12:24:27 2010
From: Nelson Elhage <nelhage@ksplice.com>
To: David Benjamin <davidben@mit.edu>, barnowl-dev@mit.edu
In-Reply-To: <1280697479-25267-1-git-send-email-davidben@mit.edu>
Date: Mon, 02 Aug 2010 12:24:21 -0400
lgtm
On Sun, 1 Aug 2010 14:17:59 -0700, David Benjamin <davidben@MIT.EDU> wrote:
> Oops. This must have only barely worked because we've been deleting
> things in the right order.
> ---
> window.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/window.c b/window.c
> index a31805c..221b42f 100644
> --- a/window.c
> +++ b/window.c
> @@ -200,6 +200,8 @@ static void _owl_window_link(owl_window *w, owl_window *parent)
> if (parent) {
> w->parent = parent;
> w->next = parent->child;
> + if (w->next)
> + w->next->prev = w;
> parent->child = w;
> g_object_ref (w);
> }
> --
> 1.7.2.1.7.gf50fd
>
>
