[2566] in BarnOwl Developers
Re: [PATCH 3/4] _owl_fmtext_append_fmtext takes an inclusive range
daemon@ATHENA.MIT.EDU (David A Benjamin)
Wed Jul 28 00:52:11 2010
Date: Wed, 28 Jul 2010 00:52:08 -0400 (EDT)
From: David A Benjamin <davidben@MIT.EDU>
To: Nelson Elhage <nelhage@mit.edu>
cc: Anders Kaseorg <andersk@mit.edu>, barnowl-dev@mit.edu
In-Reply-To: <87d3u8s8n1.fsf@mit.edu>
This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
---1257051904-255574238-1280292728=:2102
Content-Type: TEXT/PLAIN; charset=utf-8; format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
Eh, it's not that hard. I've updated this patchset and expand-tabs on top=
=20
of it.
http://github.com/davidben/barnowl/commits/master
http://github.com/davidben/barnowl/commits/expand-tabs
The test case commit now adds the tests for=20
owl_fmtext_truncate_{lines,cols} (the other callers of=20
_owl_fmtext_append_fmtext), the latter reordered from expand-tabs. And=20
then the next commit switching to a half-open range.
David
On Tue, 27 Jul 2010, Nelson Elhage wrote:
> =3D=3Dandersk, but this is an improvement if it's too much of a pain to f=
ix
> quickly (I haven't checked how many callers it has, but I can't imagine
> it being that bad).
>
> This whole series
> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
>
> On Sun, 25 Jul 2010 18:32:43 -0400 (EDT), Anders Kaseorg <andersk@MIT.EDU=
> wrote:
>> On Sun, 25 Jul 2010, David Benjamin wrote:
>>> - _owl_fmtext_append_fmtext(f, in, 0, in->textlen);
>>> + _owl_fmtext_append_fmtext(f, in, 0, in->textlen - 1);
>>
>> I=E2=80=99d rather fix this by changing _owl_fmtext_append_fmtext to tak=
e a
>> half-open range, like any sane function should.
>>
>> Anders
>>
>
---1257051904-255574238-1280292728=:2102--
