[2561] in BarnOwl Developers
Re: [PATCH 3/4] _owl_fmtext_append_fmtext takes an inclusive range
daemon@ATHENA.MIT.EDU (Nelson Elhage)
Tue Jul 27 21:22:15 2010
From: Nelson Elhage <nelhage@MIT.EDU>
To: Anders Kaseorg <andersk@mit.edu>, David Benjamin <davidben@mit.edu>
Cc: barnowl-dev@mit.edu
In-Reply-To: <alpine.DEB.2.00.1007251831460.14251@dr-wily.mit.edu>
Date: Tue, 27 Jul 2010 21:22:10 -0400
=3D=3Dandersk, but this is an improvement if it's too much of a pain to fix
quickly (I haven't checked how many callers it has, but I can't imagine
it being that bad).
This whole series
Reviewed-by: Nelson Elhage <nelhage@mit.edu>
On Sun, 25 Jul 2010 18:32:43 -0400 (EDT), Anders Kaseorg <andersk@MIT.EDU> =
wrote:
> On Sun, 25 Jul 2010, David Benjamin wrote:
> > - _owl_fmtext_append_fmtext(f, in, 0, in->textlen);
> > + _owl_fmtext_append_fmtext(f, in, 0, in->textlen - 1);
>=20
> I=E2=80=99d rather fix this by changing _owl_fmtext_append_fmtext to take=
a=20
> half-open range, like any sane function should.
>=20
> Anders
>=20
