[226] in BarnOwl Developers
[D-O-H] r402 - trunk/owl
daemon@ATHENA.MIT.EDU (asedeno@darkmatter.mit.edu)
Thu Oct 29 18:03:53 2009
Resent-From: nelhage@mit.edu
Resent-To: barnowl-dev-mtg@charon.mit.edu
To: dirty-owl-hackers@mit.edu
From: asedeno@darkmatter.mit.edu
Reply-to: dirty-owl-hackers@MIT.EDU
Date: Tue, 24 Oct 2006 14:53:52 -0400 (EDT)
Author: asedeno
Date: 2006-10-24 14:53:51 -0400 (Tue, 24 Oct 2006)
New Revision: 402
Modified:
trunk/owl/variable.c
Log:
Fixed regression tests for booleans variables. They were testing a
'string' variable.
It looks like this broke when personalbell was tweaked to accept the
name of a filter to beep on [r358]. I've changed it to test
with rxping.
--This line, and those below, will be ignored--
M owl/variable.c
Modified: trunk/owl/variable.c
===================================================================
--- trunk/owl/variable.c 2006-10-24 17:41:59 UTC (rev 401)
+++ trunk/owl/variable.c 2006-10-24 18:53:51 UTC (rev 402)
@@ -922,16 +922,16 @@
printf("BEGIN testing owl_variable\n");
FAIL_UNLESS("setup", 0==owl_variable_dict_setup(&vd));
- FAIL_UNLESS("get bool", 0==owl_variable_get_bool(&vd,"personalbell"));
+ FAIL_UNLESS("get bool", 0==owl_variable_get_bool(&vd,"rxping"));
FAIL_UNLESS("get bool (no such)", -1==owl_variable_get_bool(&vd,"mumble"));
- FAIL_UNLESS("get bool as string 1", 0==owl_variable_get_tostring(&vd,"personalbell", buf, 1024));
+ FAIL_UNLESS("get bool as string 1", 0==owl_variable_get_tostring(&vd,"rxping", buf, 1024));
FAIL_UNLESS("get bool as string 2", 0==strcmp(buf,"off"));
- FAIL_UNLESS("set bool 1", 0==owl_variable_set_bool_on(&vd,"personalbell"));
- FAIL_UNLESS("get bool 2", 1==owl_variable_get_bool(&vd,"personalbell"));
- FAIL_UNLESS("set bool 3", 0==owl_variable_set_fromstring(&vd,"personalbell","off",0,0));
- FAIL_UNLESS("get bool 4", 0==owl_variable_get_bool(&vd,"personalbell"));
- FAIL_UNLESS("set bool 5", -1==owl_variable_set_fromstring(&vd,"personalbell","xxx",0,0));
- FAIL_UNLESS("get bool 6", 0==owl_variable_get_bool(&vd,"personalbell"));
+ FAIL_UNLESS("set bool 1", 0==owl_variable_set_bool_on(&vd,"rxping"));
+ FAIL_UNLESS("get bool 2", 1==owl_variable_get_bool(&vd,"rxping"));
+ FAIL_UNLESS("set bool 3", 0==owl_variable_set_fromstring(&vd,"rxping","off",0,0));
+ FAIL_UNLESS("get bool 4", 0==owl_variable_get_bool(&vd,"rxping"));
+ FAIL_UNLESS("set bool 5", -1==owl_variable_set_fromstring(&vd,"rxping","xxx",0,0));
+ FAIL_UNLESS("get bool 6", 0==owl_variable_get_bool(&vd,"rxping"));
FAIL_UNLESS("get string", 0==strcmp("~/zlog/people", owl_variable_get_string(&vd,"logpath")));
