[1380] in BarnOwl Developers
[nelhage/barnowl] e6a4dd: Propagate regex compile failures out of filter cre...
daemon@ATHENA.MIT.EDU (noreply@github.com)
Thu Oct 29 18:16:01 2009
Resent-From: nelhage@mit.edu
Resent-To: barnowl-dev-mtg@charon.mit.edu
X-Original-To: nelhage@lunatique.mit.edu
Date: Wed, 1 Apr 2009 22:23:22 -0700
To: dirty-owl-hackers@mit.edu
From: noreply@github.com
Branch: refs/heads/master
Home: http://github.com/nelhage/barnowl
Commit: e6a4dd500610e1fa32c8e82e24d7e2fbb963f731
http://github.com/nelhage/barnowl/commit/e6a4dd500610e1fa32c8e82e24d7e2fbb963f731
Author: Nelson Elhage <nelhage@mit.edu>
Date: 2009-04-01 (Wed, 01 Apr 2009)
Changed paths:
M filter.c
M filterelement.c
Log Message:
-----------
Propagate regex compile failures out of filter creation.
Make calls to owl_filter_init_fromstring fail if the filter includes an
illegal regex (e.g. an initial *), by having owl_filterelement_create_re
return an error code which propagates up.
This fixes an issue where a command like 'unpunt class *' would segfault
because it succeeds in creating the invalid filter, but then fails to
print it successfully.
fixes: #70
