[1700] in NetBSD-Development

home help back first fref pref prev next nref lref last post

afs_readdir() and ncookies

daemon@ATHENA.MIT.EDU (Greg Hudson)
Sat Jun 13 11:14:44 1998

Date: Sat, 13 Jun 1998 11:14:31 -0400 (EDT)
From: Greg Hudson <ghudson@MIT.EDU>
To: netbsd-afs@MIT.EDU

It looks like afs_readdir() doesn't honor ncookies.  The fix should be
something like:

*** afs_vnodeops.c	Wed Mar  4 00:23:17 1998
--- afs_vnodeops.c.f	Sat Jun 13 11:13:46 1998
***************
*** 6179,6184 ****
--- 6179,6185 ----
  	    if (cookies) {
  		*cookies = origOffset /*(us + dir_NameBlobs(nde->name)) << 5*/;
  		cookies++;
+ 		ncookies--;
  	    }
  #endif
  #endif

but I'm a little worried that there are other problems in the cookie
handling in that code.

home help back first fref pref prev next nref lref last post