[10084] in The GTK GIMP ToolKit mailing list archive

home help back first fref pref prev next nref lref last post

[gtk-list] Re: wrong position of underline

daemon@ATHENA.MIT.EDU (Chi-Deok Hwang)
Fri Nov 13 18:13:50 1998

Date: Sat, 14 Nov 1998 08:13:49 +0900 (KST)
From: Chi-Deok Hwang <cdhwang@sr.hei.co.kr>
To: gtk-list@redhat.com
In-Reply-To: <87af1w6jhv.fsf@adam.kaist.ac.kr>
Resent-From: gtk-list@redhat.com
Reply-To: gtk-list@redhat.com


try the following patch:


--- gdkfont.c.orig	Fri Oct 16 23:54:00 1998
+++ gdkfont.c	Fri Oct 16 23:56:20 1998
@@ -385,13 +385,13 @@
       if (lbearing)
 	*lbearing = -ink.x;
       if (rbearing)
-	*rbearing = ink.y;
+	*rbearing = ink.width + ink.x;
       if (width)
 	*width = logical.width;
       if (ascent)
-	*ascent = ink.height;
+	*ascent = -ink.y;
       if (descent)
-	*descent = -ink.y;
+	*descent = ink.height + ink.y;
       break;
     }

On 13 Nov 1998, Changwoo Ryu wrote:

> Owen Taylor <otaylor@redhat.com> writes:
> 
> > However, this isn't very relevant, because the real problem here is
> > that the code needs to iterate character-by-character through the
> > string to determine the underlined characters, and the code isn't
> > multi-byte aware.
> > 
> > I believe that you should be able to get the underlines to display
> > properly by underlining breaking the character you want to underline
> > in two and prepending a '_' to _both_ bytes. But that really isn't the
> > right solution...
> 
> I didn't use any Korean but I got the same problem.  I deleted Korean
> messages and ran gnumeric.  The underline in "Save _as" is placed
> below `e'.
> 
> > This problem makes me wonder how underline accelerators work
> > in non-roman languages. For Korean entered on a Roman keyboard,
> > it seems relatively straightforward - I would image that
> > if the menu item was 'haemul' and 'hae' was underlined, than
> > the keyboard accelerator would be 'h'. 
> >
> Generally (at least in Korean edition of M$-Windows), we don't
> underline Korean character.  People couldn't think that `h' is the
> accelerator when they see underlined `hae'.
> 
> "haemul (_H)" has been generally used for Korean softwares.  Yes...
> As you think, it is not descriptive at all, but people can learn it
> with some hard.
> 
> > But for Japanese and Chinese the problem is much trickier - for
> > Japanese especially, going from Kanji to keyboard key does not
> > seem feasible. For these languages and probably also Korean,
> > perhaps one would want to extend the syntax of the underline
> > accelerators for menus so that: (using the Korean example)
> > 
> >   &h_(hae)(mul) 
> > 
> > would mean use 'h' as the accelerator, but don't display it, and
> > underline 'hae'. This still presents some problems when
> > dealing with non-roman keyboads. (How do you map from
> > the EUC encoding of the Japanese kana 'sa' to GDK_kana_SA?
> > Presumably you need a table.) But do Japanese and Chinese
> > language programs typically use underline accelerators
> > at all?
> 
> There are also Korean keysymbols (XK_Hangul_*).  But I have never seen
> a program or a user that uses these keysymbols.  I believe other
> languages don't use such keysymbols either.
> 
> -- 
> To unsubscribe: mail -s unsubscribe gtk-list-request@redhat.com < /dev/null
> 
> 

-- 
To unsubscribe: mail -s unsubscribe gtk-list-request@redhat.com < /dev/null


home help back first fref pref prev next nref lref last post