[295] in linux-security and linux-alert archive
Re: Tentative fix for BSD lpr
daemon@ATHENA.MIT.EDU (Florian La Roche)
Tue Jul 25 04:00:33 1995
From: Florian La Roche <florian@jurix.jura.uni-sb.de>
To: okir@monad.swb.de (Olaf Kirch)
Date: Mon, 24 Jul 1995 22:58:31 +0200 (MET DST)
Cc: linux-security@tarsier.cv.nrao.edu
Reply-To: florian@jurix.jura.uni-sb.de
In-Reply-To: <m0sZncc-00000WC@monad.swb.de> from "Olaf Kirch" at Jul 23, 95 01:06:13 am
Could someone please check out plp 4.0.2 as on ftp.iona.ie:/pub/plp
Has it also some of the BSD-lpr bugs?
I have compile it with the following patches, but I haven't tested it
yet.
Should we suggest to Linux users to use plp instead of BSD lpr?
Or someone who wants to check the current source from NetBSD, if
lpr has changed alot in it? Have they already done most of the bug-fixes?
Sorry for just posting questions and no answers...
Florian La Roche
--- Makefile.Linux
+++ Makefile.Linux 1995/07/14 10:30:21
@@ -0,0 +1,11 @@
+flags = CCOPTFLAGS='-O2 -fomit-frame-pointer -pipe'
+
+src/Makefile: src/Makefile.in
+ cd src && ./configure --prefix=/usr
+
+compile: src/Makefile
+ make $(flags) -C src
+
+install:
+ make install install.man $(flags) -C src
+
--- src/library/setuid.c
+++ src/library/setuid.c 1995/07/14 10:21:30
@@ -465,7 +465,7 @@
*args[argno] = '\0';
was_quote:
- if ((len = strcspn(cmd, meta_or_quotes_or_blanks)) != NULL) {
+ if ((len = strcspn(cmd, meta_or_quotes_or_blanks)) != 0) {
argsize += len;
args[argno] = (char *) realloc (args[argno], argsize);
}
