[3848] in linux-scsi channel archive
Re: essential fix to scsi.c (up to 2.1.100-1)
daemon@ATHENA.MIT.EDU (Linus Torvalds)
Mon May 4 14:17:46 1998
Date: Mon, 4 May 1998 10:47:05 -0700 (PDT)
From: Linus Torvalds <torvalds@transmeta.com>
To: Dario_Ballabio <Dario_Ballabio@milano.europe.dg.com>
cc: linux-scsi@vger.rutgers.edu, linux-kernel@vger.rutgers.edu
In-Reply-To: <199805041037.MAA26792@milano.europe.dg.com>
On Mon, 4 May 1998, Dario_Ballabio wrote:
>
> The enclosed patch to scsi.c, applied on top of 2.1.100-1 changed my
> PC (uniprocessor but compiled with SMP=1) with one AHA2940 and one
> DPT PM3224W from crashing every few minutes to fully reliable.
> Maybe the locking strategy in scsi_bottom_half_handler can be
> totally revisited, but the io_rw_lock is definetly required.
Good spotting, this is indeed definitely required. I had taken a look at
all the timer-based ways of entering the SCSI code, but I had _completely_
forgotten about the bottom half handler..
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.rutgers.edu
