[3638] in linux-scsi channel archive

home help back first fref pref prev next nref lref last post

Re: ncr53c875 (fwd)

daemon@ATHENA.MIT.EDU (James Bottomley)
Mon Apr 6 17:38:21 1998

To: groudier@club-internet.fr
cc: "David S. Miller" <davem@dm.cobaltmicro.com>,
        linux-kernel@vger.rutgers.edu, linux-scsi@vger.rutgers.edu,
        fw@fwconsult.com
In-reply-to: Your message of "Mon, 06 Apr 1998 20:36:35 +0200."
             <Pine.LNX.3.95.980406201514.375A-100000@localhost> 
Date: 	Mon, 06 Apr 1998 16:29:33 -0500
From: James Bottomley <James.Bottomley@columbiasc.ncr.com>

Gerard, 

davem@dm.cobaltmicro.com said:
> I looked at the changes to the NCR drivers in 2.1.92, and after having
> studing them quite a bit, there should be zero change in behavior in
> 2.1.92 on PC hardware at all.  All of the changes made it work on the
> alpha, and changed port address manipulations to use a long type
> instead of an int. 

I looked them over too.  I notice in the appended message from Francios (which 
you didn't translate) that he said 2.1.91 was working correctly.  It seems to 
me that this is probably the culprit:

@@ -9448,7 +9459,7 @@
        /*
         * Try to fix up PCI config according to wished features.
         */
-#if defined(__i386__) && !defined(MODULE)
+#if defined(__i386) && !defined(MODULE)
        if ((driver_setup.pci_fix_up & 1) &&
            (chip->features & FE_CLSE) && cache_line_size == 0) {
 #if LINUX_VERSION_CODE < LinuxVersionCode(2,1,75)

__i386 is not defined by the compiler, only __i386__.  Could Francois try 
reversing just this part of the patch?

James Bottomley



-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.rutgers.edu

home help back first fref pref prev next nref lref last post