[441] in linux-net channel archive
pre130.tar.gz net warnings
daemon@ATHENA.MIT.EDU (Paul Gortmaker)
Sun Jun 11 07:10:11 1995
From: Paul Gortmaker <gpg109@rsphy1.anu.edu.au>
To: linux-net@vger.rutgers.edu
Date: Sun, 11 Jun 1995 20:20:39 +1000 (EST)
Here are a few things I've found with the net code in pre130.tar.gz
which I assume has Alan's latest code.
1) Equalizer device defines equ_type_trans() but it is never used.
Seeing as the eql device only transmits packets, we should never
need to do a skb->protocol=... and thus dev->type_trans isn't needed
for the eql device. (I think ;)
2) ppp device has only the static prototype for ppp_type_trans. This
function needs to be added, and skb->protocol set accordingly on the
Rx packets with this function.
3) slip device -- also does not set skb->protocol on Rx'd packets.
4) The shift in the pci functions breaks the de4x5 and lance drivers.
BTW, I have finally finished isolating the Tx timeout code in all 37
drivers (major editing job) and will post that soon. There are other
small typos, a 3c501 bug Alan introduced <grin> etc. that I have fixed
and are included in that patch. Stay tuned.
Paul.
