[3586] in linux-net channel archive
net/ipv4/tcp_input.c bug
daemon@ATHENA.MIT.EDU (Carl Christofferson)
Sat Jul 6 05:06:47 1996
Date: Fri, 5 Jul 1996 23:00:40 -0700
From: Carl Christofferson <cchris@cchris.seanet.com>
To: net-patches@lxorguk.ukuu.org.uk, linux-kernel@vger.rutgers.edu
CC: linux-net@vger.rutgers.edu
A precedence problem in v2.0.2 (also v2.0.1 and v2.0.0) is fixed below
by moving a parenthesis. The bug shows up with
CONFIG_IP_TRANSPARENT_PROXY defined. The local variable r potentially
is used in a comparison before it is initialized. I did not witness
any failures from this bug.
It was pointed out by the compiler (gcc 2.7.2) as a warning.
The patch is provided as plain text and as encoded by uuencode and
mpack.
diff -u v2.0.2/linux/net/ipv4/tcp_input.c v2.0.2.1/linux/net/ipv4/tcp_input.c
--- v2.0.2/linux/net/ipv4/tcp_input.c Fri Jul 5 22:01:03 1996
+++ v2.0.2.1/linux/net/ipv4/tcp_input.c Fri Jul 5 22:54:52 1996
@@ -1863,7 +1863,7 @@
* handle them locally, due to transparent proxying.
* Thus, narrow down the test to what is really meant.
*/
- if(th->rst || !th->syn || th->ack || (r = ip_chk_addr(daddr) == IS_BROADCAST || r == IS_MULTICAST))
+ if(th->rst || !th->syn || th->ack || (r = ip_chk_addr(daddr)) == IS_BROADCAST || r == IS_MULTICAST)
#else
if(th->rst || !th->syn || th->ack || ip_chk_addr(daddr)!=IS_MYADDR)
#endif
begin 644 patch.diff
M+2TM('8R+C`N,B]L:6YU>"]N970O:7!V-"]T8W!?:6YP=70N8PE&<FD@2G5L
M("`U(#(R.C`Q.C`S(#$Y.38**RLK('8R+C`N,BXQ+VQI;G5X+VYE="]I<'8T
M+W1C<%]I;G!U="YC"49R:2!*=6P@(#4@,C(Z-30Z-3(@,3DY-@I`0"`M,3@V
M,RPW("LQ.#8S+#<@0$`*(`D)"2`J(&AA;F1L92!T:&5M(&QO8V%L;'DL(&1U
M92!T;R!T<F%N<W!A<F5N="!P<F]X>6EN9RX*(`D)"2`J(%1H=7,L(&YA<G)O
M=R!D;W=N('1H92!T97-T('1O('=H870@:7,@<F5A;&QY(&UE86YT+@H@"0D)
M("HO"BT)"0EI9BAT:"T^<G-T('Q\("%T:"T^<WEN('Q\('1H+3YA8VL@?'P@
M*'(@/2!I<%]C:&M?861D<BAD861D<BD@/3T@25-?0E)/041#05-4('Q\('(@
M/3T@25-?355,5$E#05-4*2D**PD)"6EF*'1H+3YR<W0@?'P@(71H+3YS>6X@
M?'P@=&@M/F%C:R!\?"`H<B`](&EP7V-H:U]A9&1R*&1A9&1R*2D@/3T@25-?
M0E)/041#05-4('Q\('(@/3T@25-?355,5$E#05-4*0H@(V5L<V4*(`D)"6EF
M*'1H+3YR<W0@?'P@(71H+3YS>6X@?'P@=&@M/F%C:R!\?"!I<%]C:&M?861D
=<BAD861D<BDA/4E37TU9041$4BD*("-E;F1I9@IC
`
end
This is a MIME encoded message. Decode it with "munpack"
or any other MIME reading software. Mpack/munpack is available
via anonymous FTP in ftp.andrew.cmu.edu:pub/mpack/
---
Content-Type: application/octet-stream; name="patch.diff"
Content-Transfer-Encoding: base64
Content-Disposition: inline; filename="patch.diff"
Content-MD5: 6l3kfU045QiA82cPrxs5ig==
LS0tIHYyLjAuMi9saW51eC9uZXQvaXB2NC90Y3BfaW5wdXQuYwlGcmkgSnVsICA1IDIyOjAx
OjAzIDE5OTYKKysrIHYyLjAuMi4xL2xpbnV4L25ldC9pcHY0L3RjcF9pbnB1dC5jCUZyaSBK
dWwgIDUgMjI6NTQ6NTIgMTk5NgpAQCAtMTg2Myw3ICsxODYzLDcgQEAKIAkJCSAqIGhhbmRs
ZSB0aGVtIGxvY2FsbHksIGR1ZSB0byB0cmFuc3BhcmVudCBwcm94eWluZy4KIAkJCSAqIFRo
dXMsIG5hcnJvdyBkb3duIHRoZSB0ZXN0IHRvIHdoYXQgaXMgcmVhbGx5IG1lYW50LgogCQkJ
ICovCi0JCQlpZih0aC0+cnN0IHx8ICF0aC0+c3luIHx8IHRoLT5hY2sgfHwgKHIgPSBpcF9j
aGtfYWRkcihkYWRkcikgPT0gSVNfQlJPQURDQVNUIHx8IHIgPT0gSVNfTVVMVElDQVNUKSkK
KwkJCWlmKHRoLT5yc3QgfHwgIXRoLT5zeW4gfHwgdGgtPmFjayB8fCAociA9IGlwX2Noa19h
ZGRyKGRhZGRyKSkgPT0gSVNfQlJPQURDQVNUIHx8IHIgPT0gSVNfTVVMVElDQVNUKQogI2Vs
c2UKIAkJCWlmKHRoLT5yc3QgfHwgIXRoLT5zeW4gfHwgdGgtPmFjayB8fCBpcF9jaGtfYWRk
cihkYWRkcikhPUlTX01ZQUREUikKICNlbmRpZgo=
-----
