[908] in Release_Engineering

home help back first fref pref prev next nref lref last post

Re: Bugfix code for XDrawImageString bug. OOPS.

daemon@ATHENA.MIT.EDU (Bill Cattey)
Thu Apr 13 03:29:40 1989

Date: Thu, 13 Apr 89 03:29:05 -0400 (EDT)
From: Bill Cattey <wdc@ATHENA.MIT.EDU>
To: swick@ATHENA.MIT.EDU, rel-eng@ATHENA.MIT.EDU, rt-testers@ATHENA.MIT.EDU,
Cc: tpn+@ANDREW.CMU.EDU
In-Reply-To: <cYF4h1wGG047ER0JVd@athena.mit.edu>

It's late.  I don't build X servers.  I missed one little thing.  The CORRECT
fix is:

*** miglblt.c   Thu Mar 30 09:13:04 1989
--- /tmp/miglblt.c      Thu Apr 13 03:19:46 1989
***************
*** 175,184 ****
      QueryGlyphExtents(pGC->font, ppci, (unsigned long)nglyph, &info);

      backrect.x = x;
!     backrect.y = y - pGC->font->pFI->fontAscent;
!     backrect.width = info.overallWidth;
!     backrect.height = pGC->font->pFI->fontAscent +
!                     pGC->font->pFI->fontDescent;

      oldAlu = pGC->alu;
      oldFG = pGC->fgPixel;
--- 175,184 ----
      QueryGlyphExtents(pGC->font, ppci, (unsigned long)nglyph, &info);

      backrect.x = x;
!     backrect.y = y - info.overallAscent;
!     backrect.width = info.overallRight - info.overallLeft;
!     backrect.height = info.overallAscent +
!                     info.overallDescent;

      oldAlu = pGC->alu;
      oldFG = pGC->fgPixel;

home help back first fref pref prev next nref lref last post