[907] in Release_Engineering
Bugfix code for XDrawImageString bug.
daemon@ATHENA.MIT.EDU (Bill Cattey)
Thu Apr 13 03:25:42 1989
Date: Thu, 13 Apr 89 03:24:49 -0400 (EDT)
From: Bill Cattey <wdc@ATHENA.MIT.EDU>
To: swick@ATHENA.MIT.EDU, rel-eng@ATHENA.MIT.EDU, rt-testers@ATHENA.MIT.EDU,
Cc: tpn+@ANDREW.CMU.EDU
In-Reply-To: <AYF3U3MGG047IR0IQo@athena.mit.edu>
In order to get XDrawImageString to do what it is documented to do, and to
behave sensibly, the following change must be made to servers/ddx/mi/miglblt.c:
miImageGlyphBlt. The call to QueryGlyphExtents is made. The information is all
there. It's just not used in keeping with the documentation and the sensible
action of the routine.
*** miglblt.c Thu Mar 30 09:13:04 1989
--- /tmp/miglblt.c Thu Apr 13 03:19:46 1989
***************
*** 175,184 ****
QueryGlyphExtents(pGC->font, ppci, (unsigned long)nglyph, &info);
backrect.x = x;
! backrect.y = y - pGC->font->pFI->fontAscent;
! backrect.width = info.overallWidth;
! backrect.height = pGC->font->pFI->fontAscent +
! pGC->font->pFI->fontDescent;
oldAlu = pGC->alu;
oldFG = pGC->fgPixel;
--- 175,184 ----
QueryGlyphExtents(pGC->font, ppci, (unsigned long)nglyph, &info);
backrect.x = x;
! backrect.y = y - info.overallAscent;
! backrect.width = info.overallRight - overallLeft;
! backrect.height = info.overallAscent +
! info.overallDescent;
oldAlu = pGC->alu;
oldFG = pGC->fgPixel;
