[6059] in Moira
Re: chsh's Makefile.in failes to ensure sysconfdir exists
daemon@ATHENA.MIT.EDU (Garry P Zacheiss)
Thu Jul 28 16:02:16 2011
From: Garry P Zacheiss <zacheiss@MIT.EDU>
To: Jonathan D Reed <jdreed@mit.edu>
CC: "moiradev@mit.edu" <moiradev@mit.edu>
Date: Thu, 28 Jul 2011 16:02:08 -0400
Message-ID: <247BAC08-568A-4B58-B374-0C9CFDD2ED71@mit.edu>
In-Reply-To: <alpine.DEB.2.00.1107281256160.6039@INFINITE-LOOP.mit.edu>
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Committed.
Garry
On Jul 28, 2011, at 1:02 PM, Jonathan Reed wrote:
> I believe that the Makefile.in for chsh should create sysconfdir if it
> doesn't exist. Otherwise "install -c" will simply copy shells.moira to
> $DESTDIR/etc as a regular file. Can you take the following patch or a
> similar one?
>
> Thanks,
> Jon
>
> Index: moira/clients/chsh/Makefile.in
> ===================================================================
> --- moira/clients/chsh/Makefile.in (revision 4044)
> +++ moira/clients/chsh/Makefile.in (working copy)
> @@ -46,6 +46,7 @@
>
> install: all
> $(LIBTOOL) --mode=install $(INSTALL_PROGRAM) $(TARGET) $(DESTDIR)$(bindir)
> + $(SRCTOP)/mkinstalldirs $(DESTDIR)$(sysconfdir)
> $(INSTALL) shells.moira $(DESTDIR)$(sysconfdir)
>
> $(TARGET): $(OBJS) ../lib/libmrclient.la $(MR_LIBDEP)
>
