[6058] in Moira

home help back first fref pref prev next nref lref last post

chsh's Makefile.in failes to ensure sysconfdir exists

daemon@ATHENA.MIT.EDU (Jonathan Reed)
Thu Jul 28 13:02:40 2011

Date: Thu, 28 Jul 2011 13:02:34 -0400 (EDT)
From: Jonathan Reed <jdreed@MIT.EDU>
To: moiradev@mit.edu
Message-ID: <alpine.DEB.2.00.1107281256160.6039@INFINITE-LOOP.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII

I believe that the Makefile.in for chsh should create sysconfdir if it 
doesn't exist.  Otherwise "install -c" will simply copy shells.moira to 
$DESTDIR/etc as a regular file.  Can you take the following patch or a 
similar one?

Thanks,
Jon

Index: moira/clients/chsh/Makefile.in
===================================================================
--- moira/clients/chsh/Makefile.in	(revision 4044)
+++ moira/clients/chsh/Makefile.in	(working copy)
@@ -46,6 +46,7 @@

  install: all
  	$(LIBTOOL) --mode=install $(INSTALL_PROGRAM) $(TARGET) $(DESTDIR)$(bindir)
+	$(SRCTOP)/mkinstalldirs $(DESTDIR)$(sysconfdir)
  	$(INSTALL) shells.moira $(DESTDIR)$(sysconfdir)

  $(TARGET): $(OBJS) ../lib/libmrclient.la $(MR_LIBDEP)


home help back first fref pref prev next nref lref last post