[28319] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Fix unlikely memory leak exporting lucid context

daemon@ATHENA.MIT.EDU (Greg Hudson)
Wed May 7 14:38:49 2014

Date: Wed, 7 May 2014 14:38:45 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201405071838.s47IcjZN017172@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/0477f69ba67e7071cb3671f94c466ba99f15285e
commit 0477f69ba67e7071cb3671f94c466ba99f15285e
Author: Neng Xue <xnsuda@yahoo.com>
Date:   Mon May 5 16:42:02 2014 -0700

    Fix unlikely memory leak exporting lucid context
    
    If the GSSAPI context has an unrecognized proto field (which should
    never happen), free the context we allocated before returning EINVAL.
    
    [ghudson@mit.edu: clarify commit message]

 src/lib/gssapi/krb5/lucid_context.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/lib/gssapi/krb5/lucid_context.c b/src/lib/gssapi/krb5/lucid_context.c
index dc129e1..85df7fd 100644
--- a/src/lib/gssapi/krb5/lucid_context.c
+++ b/src/lib/gssapi/krb5/lucid_context.c
@@ -215,6 +215,7 @@ make_external_lucid_ctx_v1(
         }
     }
     else {
+        xfree(lctx);
         return EINVAL;  /* XXX better error code? */
     }
 
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post