[28318] in CVS-changelog-for-Kerberos-V5
krb5 commit: Don't remove ccache creds before storing them
daemon@ATHENA.MIT.EDU (Greg Hudson)
Wed May 7 13:04:51 2014
Date: Wed, 7 May 2014 13:04:42 -0400
From: Greg Hudson <ghudson@MIT.EDU>
Message-Id: <201405071704.s47H4gFj028409@drugstore.mit.edu>
To: cvs-krb5@MIT.EDU
Reply-To: krbdev@MIT.EDU
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@MIT.EDU
https://github.com/krb5/krb5/commit/7783054742ddd807f7b2f7157d6ed81b7fb614eb
commit 7783054742ddd807f7b2f7157d6ed81b7fb614eb
Author: Greg Hudson <ghudson@mit.edu>
Date: Thu May 1 18:11:32 2014 -0400
Don't remove ccache creds before storing them
Revert #6291, which attempts to suppress duplicate credentials by
calling krb5_cc_remove in krb5_cc_store_cred. Most of our ccache
types don't implement remove_cred, and avoiding duplicate credentials
is a responsibility better suited to the ccache implementation for
atomicity reasons.
Removing this call gets rid of the misleading "Removing ... from ..."
messages in trace logs.
ticket: 7906 (new)
src/lib/krb5/ccache/ccfns.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/src/lib/krb5/ccache/ccfns.c b/src/lib/krb5/ccache/ccfns.c
index 1a0bed0..1084d51 100644
--- a/src/lib/krb5/ccache/ccfns.c
+++ b/src/lib/krb5/ccache/ccfns.c
@@ -84,9 +84,6 @@ krb5_cc_store_cred(krb5_context context, krb5_ccache cache,
krb5_ticket *tkt;
krb5_principal s1, s2;
- /* remove any dups */
- krb5_cc_remove_cred(context, cache, KRB5_TC_MATCH_AUTHDATA, creds);
-
TRACE_CC_STORE(context, cache, creds);
ret = cache->ops->store(context, cache, creds);
if (ret) return ret;
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
