[663] in arla-drinkers

home help back first fref pref prev next nref lref last post

Re: arla-0.22 + netbsd-current (19990301, i386, 1.3J) == crash

daemon@ATHENA.MIT.EDU (assar@stacken.kth.se)
Thu Mar 4 00:12:17 1999

From owner-arla-drinkers@stacken.kth.se Thu Mar 04 05:12:16 1999
Return-Path: <owner-arla-drinkers@stacken.kth.se>
Delivered-To: arla-drinkers-mtg@bloom-picayune.mit.edu
Received: (qmail 8981 invoked from network); 4 Mar 1999 05:12:15 -0000
Received: from unknown (HELO sundance.stacken.kth.se) (130.237.234.41)
  by bloom-picayune.mit.edu with SMTP; 4 Mar 1999 05:12:15 -0000
Received: (from majordom@localhost)
	by sundance.stacken.kth.se (8.8.8/8.8.8) id GAA05211
	for arla-drinkers-list; Thu, 4 Mar 1999 06:06:07 +0100 (MET)
Received: from dyn02.trafford.dementia.org (dyn02.trafford.dementia.org [204.29.154.130])
	by sundance.stacken.kth.se (8.8.8/8.8.8) with ESMTP id GAA05207
	for <arla-drinkers@stacken.kth.se>; Thu, 4 Mar 1999 06:06:00 +0100 (MET)
Received: (from assar@localhost) by dyn02.trafford.dementia.org (8.9.1/8.7.3) id GAA81628; Thu, 4 Mar 1999 06:08:29 +0100 (CET)
From: assar@stacken.kth.se
To: Johan Ihren <johani@pdc.kth.se>
Cc: arla-drinkers@stacken.kth.se
Subject: Re: arla-0.22 + netbsd-current (19990301, i386, 1.3J) == crash
References: <199903040250.DAA00184@wanda.pdc.kth.se>
Mime-Version: 1.0 (generated by tm-edit 7.68)
Content-Type: multipart/mixed;
 boundary="Multipart_Thu_Mar__4_06:08:25_1999-1"
Content-Transfer-Encoding: 7bit
Date: 04 Mar 1999 06:08:25 +0100
In-Reply-To: Johan Ihren's message of "Thu, 4 Mar 1999 03:50:57 +0100 (CET)"
Message-ID: <5llnhd3kqe.fsf@mg.trafford.dementia.org>
Lines: 92
X-Mailer: Gnus v5.5/Emacs 19.34
Sender: owner-arla-drinkers@stacken.kth.se
Precedence: bulk

--Multipart_Thu_Mar__4_06:08:25_1999-1
Content-Type: text/plain; charset=US-ASCII

Johan Ihren <johani@pdc.kth.se> writes:
> db> trace
> _vfs_opv_init(...)
> _vfs_attach(...)
> _end(...)
> _end(...)
> _end(...)
> _end(...)
> _lkmioctl(...)
> _spec_ioctl(...)
> _vn_ioctl(...)
> _sys_ioctl(...)
> _syscall(...)
> ----- syscall (#54) ----

Now I don't have a netbsd-box to test this on, but from looking at the
code it seems like that the following patch might help.  You need to
run `autoreconf -f' and then re-run configur after having applied this
patch.  If you get any warnings while compiling the xfs module at all
please send them to me as they could indicate that something is wrong.

/assar

--Multipart_Thu_Mar__4_06:08:25_1999-1
Content-Type: text/plain; charset=US-ASCII

Index: acconfig.h
===================================================================
RCS file: /usr/local/cvsroot/arla/acconfig.h,v
retrieving revision 1.74
diff -u -w -r1.74 acconfig.h
--- acconfig.h	1999/02/26 00:52:24	1.74
+++ acconfig.h	1999/03/04 04:59:27
@@ -288,6 +288,9 @@
 /* Define if your struct vfsops has a field vfs_oid */
 #undef HAVE_STRUCT_VFSOPS_VFS_OID
 
+/* Define if your struct vfsops has a field vfs_checkexp */
+#undef HAVE_STRUCT_VFSOPS_VFS_CHECKEXP
+
 /* Define if your struct vfsops has a field vfs_uninit */
 #undef HAVE_STRUCT_VFSOPS_VFS_UNINIT
 
Index: configure.in
===================================================================
RCS file: /usr/local/cvsroot/arla/configure.in,v
retrieving revision 1.254
diff -u -w -r1.254 configure.in
--- configure.in	1999/03/04 01:36:05	1.254
+++ configure.in	1999/03/04 04:59:31
@@ -1038,6 +1038,15 @@
 AC_HAVE_KERNEL_STRUCT_FIELD([
 #include <sys/types.h>
 #include <sys/param.h>
+#include <sys/mount.h>
+],
+vfsops,
+void *,
+vfs_checkexp)
+
+AC_HAVE_KERNEL_STRUCT_FIELD([
+#include <sys/types.h>
+#include <sys/param.h>
 #include <sys/vnode.h>
 #include <sys/vnode_if.h>
 ],
Index: xfs/bsd/xfs_vfsops-netbsd.c
===================================================================
RCS file: /usr/local/cvsroot/arla/xfs/bsd/xfs_vfsops-netbsd.c,v
retrieving revision 1.10
diff -u -w -r1.10 xfs_vfsops-netbsd.c
--- xfs_vfsops-netbsd.c	1998/12/28 16:05:21	1.10
+++ xfs_vfsops-netbsd.c	1999/03/04 04:59:53
@@ -125,8 +125,11 @@
     xfs_fhtovp,
     xfs_vptofh,
     xfs_init,
-    NULL,
-    NULL,
+    NULL,			/* sysctl */
+    NULL,			/* mountroot */
+#ifdef HAVE_STRUCT_VFSOPS_VFS_CHECKEXP
+    NULL,			/* checkexp */
+#endif
 #ifdef HAVE_STRUCT_VFSOPS_VFS_OPV_DESCS
     xfs_vnodeopv_descs
 #endif

--Multipart_Thu_Mar__4_06:08:25_1999-1--

home help back first fref pref prev next nref lref last post