[593] in arla-drinkers
Re: More arla panic and oops info on linux 2.2.1
daemon@ATHENA.MIT.EDU (Magnus Ahltorp)
Fri Feb 5 19:58:50 1999
From owner-arla-drinkers@stacken.kth.se Sat Feb 06 00:58:48 1999
Return-Path: <owner-arla-drinkers@stacken.kth.se>
Delivered-To: arla-drinkers-mtg@bloom-picayune.mit.edu
Received: (qmail 17638 invoked from network); 6 Feb 1999 00:58:46 -0000
Received: from unknown (HELO sundance.stacken.kth.se) (130.237.234.41)
by bloom-picayune.mit.edu with SMTP; 6 Feb 1999 00:58:46 -0000
Received: (from majordom@localhost)
by sundance.stacken.kth.se (8.8.8/8.8.8) id BAA18235
for arla-drinkers-list; Sat, 6 Feb 1999 01:52:25 +0100 (MET)
Received: from mumrik.nada.kth.se (mumrik.nada.kth.se [130.237.226.10])
by sundance.stacken.kth.se (8.8.8/8.8.8) with ESMTP id BAA18231
for <arla-drinkers@stacken.kth.se>; Sat, 6 Feb 1999 01:52:19 +0100 (MET)
Received: (from d95-mah@localhost)
by mumrik.nada.kth.se (8.8.7/8.8.7) id BAA08973;
Sat, 6 Feb 1999 01:52:11 +0100 (MET)
To: "Neulinger, Nathan R." <nneul@umr.edu>
Cc: arla-drinkers@stacken.kth.se
Subject: Re: More arla panic and oops info on linux 2.2.1
References: <9DA8D24B915BD1118911006094516EAF019C7EDB@umr-mail02.cc.umr.edu>
From: Magnus Ahltorp <map@stacken.kth.se>
Date: 06 Feb 1999 01:52:10 +0100
In-Reply-To: "Neulinger, Nathan R."'s message of "Fri, 5 Feb 1999 16:07:06 -0600"
Message-ID: <ixdiudgcq11.fsf@mumrik.nada.kth.se>
Lines: 38
X-Mailer: Gnus v5.6.45/Emacs 19.34
Sender: owner-arla-drinkers@stacken.kth.se
Precedence: bulk
Try this patch. It should at least keep the system from oops:ing. I
have not investigated further why the cache file handle is unassigned.
Index: xfs_inodeops.c
===================================================================
RCS file: /usr/local/cvsroot/arla/xfs/linux/xfs_inodeops.c,v
retrieving revision 1.77
diff -u -r1.77 xfs_inodeops.c
--- xfs_inodeops.c 1999/01/30 16:38:34 1.77
+++ xfs_inodeops.c 1999/02/06 00:40:16
@@ -947,6 +947,10 @@
if (error)
return error;
+ if (DATA_FROM_VNODE(xfs_inode) == NULL) {
+ printk(KERN_EMERG "XFS Panic: readpage on NULL cache file\n");
+ return -EINVAL;
+ }
cache_inode = DENTRY_TO_INODE(DATA_FROM_VNODE(xfs_inode));
cache_dentry = d_alloc(NULL, &(const struct qstr) { "xfs cache file", 14, 0});
Index: xfs_vfsops.c
===================================================================
RCS file: /usr/local/cvsroot/arla/xfs/linux/xfs_vfsops.c,v
retrieving revision 1.39
diff -u -r1.39 xfs_vfsops.c
--- xfs_vfsops.c 1999/01/15 14:19:21 1.39
+++ xfs_vfsops.c 1999/02/06 00:40:16
@@ -346,7 +346,7 @@
XFS_TOKEN_CLEAR(xn, XFS_ATTR_VALID, XFS_ATTR_MASK);
}
- return -error;
+ return error;
}
#ifndef LINUX2_1
