[4942] in arla-drinkers
Re: SV: PATCH: Arla CVS Current on Linux 2.6.24-2.6.35-rc1
daemon@ATHENA.MIT.EDU (=?ISO-8859-1?Q?Bo_Brant=E9n?=)
Sun Jul 11 12:30:07 2010
From arla-drinkers-bounces@stacken.kth.se Sun Jul 11 16:30:07 2010
Return-Path: <arla-drinkers-bounces@stacken.kth.se>
Delivered-To: arla-drinkers-mtg@bloom-picayune.mit.edu
Received: (qmail 896 invoked from network); 11 Jul 2010 16:30:06 -0000
Received: from mx2.kth.se (130.237.48.98)
by charon.mit.edu with SMTP; 11 Jul 2010 16:30:06 -0000
X-KTH-mail-from: arla-drinkers-bounces@stacken.kth.se
Received: from mx4.kth.se (mx4.kth.se [130.237.48.62])
by mx2.kth.se (Postfix) with ESMTP id 11C1510A183;
Sun, 11 Jul 2010 18:30:05 +0200 (CEST)
X-Virus-Scanned: by amavisd-new at kth.se
Received: from mx2.kth.se ([130.237.48.98])
by mx4.kth.se (mx4.kth.se [130.237.48.62]) (amavisd-new, port 10024)
with LMTP id MuX1QEJmPs7b; Sun, 11 Jul 2010 18:30:03 +0200 (CEST)
X-KTH-mail-from: arla-drinkers-bounces@stacken.kth.se
Received: from tapas.stacken.kth.se (tapas.stacken.kth.se [130.237.234.140])
by mx2.kth.se (Postfix) with ESMTP id 93224109729;
Sun, 11 Jul 2010 18:29:53 +0200 (CEST)
Received: from tapas.stacken.kth.se (localhost [127.0.0.1])
by tapas.stacken.kth.se (Postfix) with ESMTP id 437C751D64;
Sun, 11 Jul 2010 18:29:53 +0200 (CEST)
X-Original-To: arla-drinkers@tapas.stacken.kth.se
Delivered-To: arla-drinkers@tapas.stacken.kth.se
Received: from brev.stacken.kth.se (brev.stacken.kth.se [130.237.234.84])
by tapas.stacken.kth.se (Postfix) with ESMTP id 80F8A51D64
for <arla-drinkers@tapas.stacken.kth.se>;
Sun, 11 Jul 2010 18:29:50 +0200 (CEST)
Received: from mx2.kth.se (mx2.kth.se [130.237.48.98])
by brev.stacken.kth.se (8.12.10/8.12.10) with ESMTP id o6BGTobc009692
for <arla-drinkers@stacken.kth.se>;
Sun, 11 Jul 2010 18:29:50 +0200 (MET DST)
X-KTH-mail-from: bosse@acc.umu.se
X-KTH-rcpt-to: arla-drinkers@stacken.kth.se
Received: from mx4.kth.se (mx4.kth.se [130.237.48.62])
by mx2.kth.se (Postfix) with ESMTP id D080C10977D
for <arla-drinkers@stacken.kth.se>;
Sun, 11 Jul 2010 18:29:44 +0200 (CEST)
X-Virus-Scanned: by amavisd-new at kth.se
Received: from mx2.kth.se ([130.237.48.98])
by mx4.kth.se (mx4.kth.se [130.237.48.62]) (amavisd-new, port 10024)
with LMTP id b8I41PsHlhWx for <arla-drinkers@stacken.kth.se>;
Sun, 11 Jul 2010 18:29:40 +0200 (CEST)
X-KTH-mail-from: bosse@acc.umu.se
X-KTH-rcpt-to: arla-drinkers@stacken.kth.se
Received: from mail.acc.umu.se (mail.acc.umu.se [IPv6:2001:6b0:e:2018::156])
by mx2.kth.se (Postfix) with ESMTP id F2F6E109729
for <arla-drinkers@stacken.kth.se>;
Sun, 11 Jul 2010 18:29:39 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
by amavisd-new (Postfix) with ESMTP id A24131EB;
Sun, 11 Jul 2010 18:29:39 +0200 (MEST)
X-Virus-Scanned: amavisd-new at acc.umu.se
Received: from stalin.acc.umu.se (stalin.acc.umu.se [130.239.18.135])
by mail.acc.umu.se (Postfix) with ESMTP id 45C531EA;
Sun, 11 Jul 2010 18:29:38 +0200 (MEST)
Received: by stalin.acc.umu.se (Postfix, from userid 10005)
id 232092D; Sun, 11 Jul 2010 18:29:38 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
by stalin.acc.umu.se (Postfix) with ESMTP id 1484F2C;
Sun, 11 Jul 2010 18:29:38 +0200 (CEST)
Date: Sun, 11 Jul 2010 18:29:38 +0200 (CEST)
From: =?ISO-8859-1?Q?Bo_Brant=E9n?= <bosse@acc.umu.se>
To: Tomas Olsson <tol@kth.se>
Subject: Re: SV: PATCH: Arla CVS Current on Linux 2.6.24-2.6.35-rc1
In-Reply-To: <6EA5D2AF40F2C948A46828308DB8AFEF01E796@EXDB1.ug.kth.se>
Message-ID: <Pine.A41.4.64.1007111824070.540840@stalin.acc.umu.se>
References: <Pine.A41.4.64.1006041527500.819408@stalin.acc.umu.se>
<Pine.A41.4.64.1006051131380.1097872@stalin.acc.umu.se>,
<Pine.A41.4.64.1006051835290.549032@stalin.acc.umu.se>
<6EA5D2AF40F2C948A46828308DB8AFEF01E796@EXDB1.ug.kth.se>
MIME-Version: 1.0
Cc: "arla-drinkers@stacken.kth.se" <arla-drinkers@stacken.kth.se>
X-BeenThere: arla-drinkers@stacken.kth.se
X-Mailman-Version: 2.1.6
Precedence: list
List-Id: Arla discussions <arla-drinkers.stacken.kth.se>
List-Unsubscribe: <https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers>,
<mailto:arla-drinkers-request@stacken.kth.se?subject=unsubscribe>
List-Archive: <http://lists.stacken.kth.se/pipermail/arla-drinkers>
List-Post: <mailto:arla-drinkers@stacken.kth.se>
List-Help: <mailto:arla-drinkers-request@stacken.kth.se?subject=help>
List-Subscribe: <https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers>,
<mailto:arla-drinkers-request@stacken.kth.se?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: arla-drinkers-bounces@stacken.kth.se
Errors-To: arla-drinkers-bounces@stacken.kth.se
On Tue, 29 Jun 2010, Tomas Olsson wrote:
> We may be leaking group_info references in nnpfs_get_pag_group() and store_pag().
Yes, the reference count is decremented with put_group_info() but it is
two possible ways to fix it, I think the second one is the most correct:
nnpfs_get_pag_group(void)
{
#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,28)
struct group_info *gi = current->group_info;
nnpfs_pag_t ret = current->uid;
#else
struct group_info *gi = get_current_groups();
nnpfs_pag_t ret = current_uid();
#endif
int i;
get_group_info(gi);
i = find_pag(gi);
if (i != NNPFS_PAG_NOTFOUND)
ret = GROUP_AT(gi, i);
put_group_info(gi);
#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,28)
put_group_info(gi);
#endif
NNPFSDEB(XDEBSYS, ("nnpfs_get_pag_group: returning %u\n", ret));
return ret;
}
nnpfs_get_pag_group(void)
{
#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,28)
struct group_info *gi = current->group_info;
nnpfs_pag_t ret = current->uid;
#else
struct group_info *gi = get_current_groups();
nnpfs_pag_t ret = current_uid();
#endif
int i;
#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,28)
get_group_info(gi);
#endif
i = find_pag(gi);
if (i != NNPFS_PAG_NOTFOUND)
ret = GROUP_AT(gi, i);
put_group_info(gi);
NNPFSDEB(XDEBSYS, ("nnpfs_get_pag_group: returning %u\n", ret));
return ret;
}
Bo Branten
_______________________________________________
Arla-drinkers mailing list
Arla-drinkers@stacken.kth.se
https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers
