[477] in arla-drinkers
Re: 12-28 snapshot on netbsd1.3H - much better luck this time
daemon@ATHENA.MIT.EDU (assar@stacken.kth.se)
Sat Jan 9 20:33:06 1999
From owner-arla-drinkers@stacken.kth.se Sun Jan 10 01:33:05 1999
Return-Path: <owner-arla-drinkers@stacken.kth.se>
Delivered-To: arla-drinkers-mtg@bloom-picayune.mit.edu
Received: (qmail 2599 invoked from network); 10 Jan 1999 01:33:04 -0000
Received: from unknown (HELO sundance.stacken.kth.se) (130.237.234.41)
by bloom-picayune.mit.edu with SMTP; 10 Jan 1999 01:33:04 -0000
Received: (from majordom@localhost)
by sundance.stacken.kth.se (8.8.8/8.8.8) id CAA23891
for arla-drinkers-list; Sun, 10 Jan 1999 02:28:23 +0100 (MET)
Received: from assaris2.pdc.kth.se (assaris2.pdc.kth.se [130.237.221.57])
by sundance.stacken.kth.se (8.8.8/8.8.8) with ESMTP id CAA23882
for <arla-drinkers@stacken.kth.se>; Sun, 10 Jan 1999 02:28:17 +0100 (MET)
Received: (from assar@localhost) by assaris2.pdc.kth.se (8.9.1/8.7.3) id CAA44859; Sun, 10 Jan 1999 02:29:08 +0100 (CET)
From: assar@stacken.kth.se
To: Ken Raeburn <raeburn@raeburn.org>
Cc: arla-drinkers@stacken.kth.se
Subject: Re: 12-28 snapshot on netbsd1.3H - much better luck this time
References: <199812291646.LAA07921@kr-pc.cygnus.com> <5lempiho24.fsf@assaris.sics.se> <tx1btkm4yvp.fsf@raeburn.org> <5l90fqhkva.fsf@assaris.sics.se> <tx1k8yw822n.fsf@raeburn.org>
Mime-Version: 1.0 (generated by tm-edit 7.68)
Content-Type: multipart/mixed;
boundary="Multipart_Sun_Jan_10_02:29:06_1999-1"
Content-Transfer-Encoding: 7bit
Date: 10 Jan 1999 02:29:06 +0100
In-Reply-To: Ken Raeburn's message of "09 Jan 1999 18:21:36 -0500"
Message-ID: <5logo7ud99.fsf@assaris2.pdc.kth.se>
Lines: 109
X-Mailer: Gnus v5.5/Emacs 19.34
Sender: owner-arla-drinkers@stacken.kth.se
Precedence: bulk
--Multipart_Sun_Jan_10_02:29:06_1999-1
Content-Type: text/plain; charset=US-ASCII
Ken Raeburn <raeburn@raeburn.org> writes:
> In the copy of src/domestic/lib/libkafs/afssysdefs.h I've got, there
> is no such definition, and the version is 1.2 dated 1995/12/17.
> Checking the netbsd-current sources on ftp.netbsd.org yields the same
> result.
I would humbly suggest you might ask NetBSD to import some more
modern code.
> % /usr/arla/bin/fs gcpags
> getcrypt: extraneous arguments ignored
> fs : error Bad address (14) return from pioctl
> %
>
> The first message appears to be because argc should be 1 when gc_cmd
> is called with no arguments, and the printed routine name is wrong; I
> haven't looked into the second.
Exactly. gcpags doesn't do anything at all in arla, but I added
support for it anyway. :-)
/assar
--Multipart_Sun_Jan_10_02:29:06_1999-1
Content-Type: text/plain; charset=US-ASCII
Index: appl/fs.c
===================================================================
RCS file: /usr/local/cvsroot/arla/appl/fs.c,v
retrieving revision 1.62
diff -u -w -u -w -r1.62 fs.c
--- fs.c 1999/01/04 23:08:24 1.62
+++ fs.c 1999/01/10 01:26:18
@@ -402,8 +402,11 @@
{
int ret;
+ argc--;
+ argv++;
+
if (argc != 0)
- printf ("getcrypt: extraneous arguments ignored\n");
+ printf ("gcpags: extraneous arguments ignored\n");
ret = fs_gcpags();
if (ret)
Index: appl/fs_lib.c
===================================================================
RCS file: /usr/local/cvsroot/arla/appl/fs_lib.c,v
retrieving revision 1.21
diff -u -w -u -w -r1.21 fs_lib.c
--- fs_lib.c 1999/01/04 21:59:13 1.21
+++ fs_lib.c 1999/01/10 01:26:39
@@ -386,7 +386,15 @@
int
fs_gcpags(void)
{
- if (k_pioctl(NULL, VIOC_GCPAGS, NULL, 0) != 0)
+ struct ViceIoctl a_params;
+
+ a_params.in_size = 0;
+ a_params.out_size = 0;
+ a_params.in = NULL;
+ a_params.out = NULL;
+
+
+ if (k_pioctl(NULL, VIOC_GCPAGS, &a_params, 0) != 0)
return errno;
return 0;
Index: arlad/messages.c
===================================================================
RCS file: /usr/local/cvsroot/arla/arlad/messages.c,v
retrieving revision 1.113
diff -u -w -u -w -r1.113 messages.c
--- messages.c 1999/01/03 08:10:57 1.113
+++ messages.c 1999/01/10 01:26:58
@@ -2870,6 +2903,16 @@
}
/*
+ * GC pags --- there shouldn't be any need to do anything here.
+ */
+
+static int
+vioc_gcpags (int fd, struct xfs_message_pioctl *h, u_int size)
+{
+ return 0;
+}
+
+/*
* Handle a pioctl message in `h'
*/
@@ -2961,6 +3004,9 @@
return viocaviator (fd, h, size);
case VIOC_ARLADEBUG :
return vioc_arladebug (fd, h, size);
+ case VIOC_GCPAGS :
+ error = vioc_gcpags (fd, h, size);
+ break;
default:
arla_warnx (ADEBMSG, "unknown pioctl call %d", h->opcode);
error = EINVAL ;
--Multipart_Sun_Jan_10_02:29:06_1999-1--
