[4300] in arla-drinkers
Re: Patches to get Arla running on FreeBSD 8-CURRENT
daemon@ATHENA.MIT.EDU (Robert Watson)
Mon Feb 25 17:23:01 2008
From arla-drinkers-bounces@stacken.kth.se Mon Feb 25 22:23:01 2008
Return-Path: <arla-drinkers-bounces@stacken.kth.se>
Delivered-To: arla-drinkers-mtg@bloom-picayune.mit.edu
Received: (qmail 994 invoked from network); 25 Feb 2008 22:23:01 -0000
Received: from mx3.kth.se (130.237.48.97)
by charon.mit.edu with SMTP; 25 Feb 2008 22:23:01 -0000
Received: from localhost (localhost [127.0.0.1])
by mx3.kth.se (Postfix) with ESMTP id 72E756A206;
Mon, 25 Feb 2008 23:22:58 +0100 (CET)
X-Virus-Scanned: by amavisd-new at kth.se
Received: from mx3.kth.se ([127.0.0.1])
by localhost (mx3.kth.se [127.0.0.1]) (amavisd-new, port 10024)
with LMTP id rb-DdkYLq+Rs; Mon, 25 Feb 2008 23:22:55 +0100 (CET)
Received: from tapas.stacken.kth.se (tapas.stacken.kth.se [130.237.234.140])
by mx3.kth.se (Postfix) with ESMTP id 4D76B68070;
Mon, 25 Feb 2008 23:22:45 +0100 (CET)
Received: from tapas.stacken.kth.se (localhost [127.0.0.1])
by tapas.stacken.kth.se (Postfix) with ESMTP id C05C653511;
Mon, 25 Feb 2008 23:22:44 +0100 (CET)
X-Original-To: arla-drinkers@tapas.stacken.kth.se
Delivered-To: arla-drinkers@tapas.stacken.kth.se
Received: from brev.stacken.kth.se (brev.stacken.kth.se [130.237.234.84])
by tapas.stacken.kth.se (Postfix) with ESMTP id 554C953511
for <arla-drinkers@tapas.stacken.kth.se>;
Mon, 25 Feb 2008 23:22:42 +0100 (CET)
Received: from mx3.kth.se (mx3.kth.se [130.237.48.97])
by brev.stacken.kth.se (8.12.10/8.12.10) with ESMTP id m1PMMfEX010113;
Mon, 25 Feb 2008 23:22:41 +0100 (MET)
Received: from localhost (localhost [127.0.0.1])
by mx3.kth.se (Postfix) with ESMTP id 79BD868070;
Mon, 25 Feb 2008 23:22:36 +0100 (CET)
X-Virus-Scanned: by amavisd-new at kth.se
X-Spam-Flag: NO
X-Spam-Score: -0.099
X-Spam-Level:
X-Spam-Status: No, score=-0.099 tagged_above=-200 required=5
tests=[BAYES_00=-2.599, SPF_SOFTFAIL=2.5]
Received: from mx3.kth.se ([127.0.0.1])
by localhost (mx3.kth.se [127.0.0.1]) (amavisd-new, port 10024)
with LMTP id A1SgeV4da-Xv; Mon, 25 Feb 2008 23:22:34 +0100 (CET)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
by mx3.kth.se (Postfix) with ESMTP id 1625A68082;
Mon, 25 Feb 2008 23:22:29 +0100 (CET)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
by cyrus.watson.org (Postfix) with ESMTP id 0D6B546B16;
Mon, 25 Feb 2008 17:22:26 -0500 (EST)
Date: Mon, 25 Feb 2008 22:22:25 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Alec Kloss <alec-keyword-arla.4d43de@SetFilePointer.com>
Subject: Re: Patches to get Arla running on FreeBSD 8-CURRENT
In-Reply-To: <20080225221533.GH28956@hamlet.SetFilePointer.com>
Message-ID: <20080225221920.A46736@fledge.watson.org>
References: <1203286882.16414.3.camel@heterodyne.kaj>
<20080218012608.V96329@fledge.watson.org>
<20080222125207.GD38141@hamlet.setfilepointer.com>
<20080223092516.O23969@fledge.watson.org>
<20080223102922.GF38141@hamlet.setfilepointer.com>
<20080223110549.GG38141@hamlet.setfilepointer.com>
<20080223161249.GH38141@hamlet.setfilepointer.com>
<1203788012.4065.10.camel@hippo.t.nxs.se>
<1203893910.4068.14.camel@hippo.t.nxs.se>
<20080225211424.U46736@fledge.watson.org>
<20080225221533.GH28956@hamlet.SetFilePointer.com>
MIME-Version: 1.0
Cc: afs@FreeBSD.org, arla-drinkers@stacken.kth.se,
Tomas Olsson <tol@stacken.kth.se>
X-BeenThere: arla-drinkers@stacken.kth.se
X-Mailman-Version: 2.1.6
Precedence: list
List-Id: Arla discussions <arla-drinkers.stacken.kth.se>
List-Unsubscribe: <https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers>,
<mailto:arla-drinkers-request@stacken.kth.se?subject=unsubscribe>
List-Archive: <http://lists.stacken.kth.se/pipermail/arla-drinkers>
List-Post: <mailto:arla-drinkers@stacken.kth.se>
List-Help: <mailto:arla-drinkers-request@stacken.kth.se?subject=help>
List-Subscribe: <https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers>,
<mailto:arla-drinkers-request@stacken.kth.se?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: arla-drinkers-bounces@stacken.kth.se
Errors-To: arla-drinkers-bounces@stacken.kth.se
On Mon, 25 Feb 2008, Alec Kloss wrote:
> I can shed a little light. It's definitely broken now as fs nnpfsdeb
> almost-all has no effect. I added the check for PRIV_NNPFS_DEBUG in
> nnpfs_common-bsd.c:
>
> +#elif defined(HAVE_KERNEL_PRIV_CHECK) && defined(PRIV_NNPFS_DEBUG)
>
> because on my -current box PRIV_NNPFS_DEBUG isn't defined. I thought it
> might be an OpenBSD-ism. Regardless, I would think it *should* fall back to
> checking with suser() but apparently it doesn't. I can investigate a bit
> more, but removing nnpfs_deb.h must have broader impact than we though.
> Robert, any thoughts about what PRIV_NNPFS_DEBUG should be?
PRIV_NNPFS_DEBUG is a definition that will appear in FreeBSD 7.1, but 7.0 was
already in final freeze when I added it to 8.x + 7.x. The reason I didn't
have a specific check for PRIV_NNPFS_DEBUG is that I adapted nnpfs for 8.x,
but not 7.0. If priv(9) is present but not PRIV_NNPFS_DEBUG, we should use
PRIV_ROOT for now.
>> With respect to (2), I need to look at the details, but I believe this has
>> to do with the fact that nnpfs is relying on generated files that may not
>> be present in a kernel source tree. The more right fix may be to force
>> generation of the files (if we can) in the nnpfs build, as we already do
>> for vnode_if.h, but I'll have to look in more detail.
>
> I think this is correct too. Things like machine/endian.h aren't in the
> kernel tree. I should be able to autoconf this for just FreeBSD if that's
> how we want to approach this. If you want to have configure generate these
> headers like vnode_if.h, I'll probably need a few hints, but I'll do what I
> can.
Indeed, it was machine/endian.h that did it.
Robert N M Watson
Computer Laboratory
University of Cambridge
_______________________________________________
Arla-drinkers mailing list
Arla-drinkers@stacken.kth.se
https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers
