[4298] in arla-drinkers
Re: Patches to get Arla running on FreeBSD 8-CURRENT
daemon@ATHENA.MIT.EDU (Robert Watson)
Mon Feb 25 16:19:57 2008
From arla-drinkers-bounces@stacken.kth.se Mon Feb 25 21:19:57 2008
Return-Path: <arla-drinkers-bounces@stacken.kth.se>
Delivered-To: arla-drinkers-mtg@bloom-picayune.mit.edu
Received: (qmail 25869 invoked from network); 25 Feb 2008 21:19:57 -0000
Received: from mx1.kth.se (130.237.32.140)
by charon.mit.edu with SMTP; 25 Feb 2008 21:19:57 -0000
Received: from localhost (localhost [127.0.0.1])
by mx1.kth.se (Postfix) with ESMTP id 1B5D816C123;
Mon, 25 Feb 2008 22:19:56 +0100 (CET)
X-Virus-Scanned: by amavisd-new at kth.se
Received: from mx1.kth.se ([127.0.0.1])
by localhost (mx1.kth.se [127.0.0.1]) (amavisd-new, port 10024)
with LMTP id hPgqf7H9L9A1; Mon, 25 Feb 2008 22:19:54 +0100 (CET)
Received: from tapas.stacken.kth.se (tapas.stacken.kth.se [130.237.234.140])
by mx1.kth.se (Postfix) with ESMTP id B7FFCFD29B;
Mon, 25 Feb 2008 22:19:40 +0100 (CET)
Received: from tapas.stacken.kth.se (localhost [127.0.0.1])
by tapas.stacken.kth.se (Postfix) with ESMTP id 616A553511;
Mon, 25 Feb 2008 22:19:40 +0100 (CET)
X-Original-To: arla-drinkers@tapas.stacken.kth.se
Delivered-To: arla-drinkers@tapas.stacken.kth.se
Received: from brev.stacken.kth.se (brev.stacken.kth.se [130.237.234.84])
by tapas.stacken.kth.se (Postfix) with ESMTP id D5F8A53511
for <arla-drinkers@tapas.stacken.kth.se>;
Mon, 25 Feb 2008 22:19:38 +0100 (CET)
Received: from mx2.kth.se (mx2.kth.se [130.237.48.98])
by brev.stacken.kth.se (8.12.10/8.12.10) with ESMTP id m1PLJbEX009554;
Mon, 25 Feb 2008 22:19:38 +0100 (MET)
Received: from localhost (localhost [127.0.0.1])
by mx2.kth.se (Postfix) with ESMTP id AC79D109FCA;
Mon, 25 Feb 2008 22:19:32 +0100 (CET)
X-Virus-Scanned: by amavisd-new at kth.se
X-Spam-Flag: NO
X-Spam-Score: -0.099
X-Spam-Level:
X-Spam-Status: No, score=-0.099 tagged_above=-200 required=5
tests=[BAYES_00=-2.599, SPF_SOFTFAIL=2.5]
Received: from mx2.kth.se ([127.0.0.1])
by localhost (mx2.kth.se [127.0.0.1]) (amavisd-new, port 10024)
with LMTP id TjRnimptOMgS; Mon, 25 Feb 2008 22:19:29 +0100 (CET)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
by mx2.kth.se (Postfix) with ESMTP id BAB0C109707;
Mon, 25 Feb 2008 22:19:26 +0100 (CET)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
by cyrus.watson.org (Postfix) with ESMTP id E91B846B5C;
Mon, 25 Feb 2008 16:19:24 -0500 (EST)
Date: Mon, 25 Feb 2008 21:19:24 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Tomas Olsson <tol@stacken.kth.se>
Subject: Re: Patches to get Arla running on FreeBSD 8-CURRENT
In-Reply-To: <1203893910.4068.14.camel@hippo.t.nxs.se>
Message-ID: <20080225211424.U46736@fledge.watson.org>
References: <20080216035658.W93919@fledge.watson.org>
<1203286882.16414.3.camel@heterodyne.kaj>
<20080218012608.V96329@fledge.watson.org>
<20080222125207.GD38141@hamlet.setfilepointer.com>
<20080223092516.O23969@fledge.watson.org>
<20080223102922.GF38141@hamlet.setfilepointer.com>
<20080223110549.GG38141@hamlet.setfilepointer.com>
<20080223161249.GH38141@hamlet.setfilepointer.com>
<1203788012.4065.10.camel@hippo.t.nxs.se>
<1203893910.4068.14.camel@hippo.t.nxs.se>
MIME-Version: 1.0
Cc: Alec Kloss <alec-keyword-arla.4d43de@SetFilePointer.com>, afs@FreeBSD.org,
arla-drinkers@stacken.kth.se
X-BeenThere: arla-drinkers@stacken.kth.se
X-Mailman-Version: 2.1.6
Precedence: list
List-Id: Arla discussions <arla-drinkers.stacken.kth.se>
List-Unsubscribe: <https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers>,
<mailto:arla-drinkers-request@stacken.kth.se?subject=unsubscribe>
List-Archive: <http://lists.stacken.kth.se/pipermail/arla-drinkers>
List-Post: <mailto:arla-drinkers@stacken.kth.se>
List-Help: <mailto:arla-drinkers-request@stacken.kth.se?subject=help>
List-Subscribe: <https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers>,
<mailto:arla-drinkers-request@stacken.kth.se?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: arla-drinkers-bounces@stacken.kth.se
Errors-To: arla-drinkers-bounces@stacken.kth.se
On Sun, 24 Feb 2008, Tomas Olsson wrote:
> I wrote:
>> On Sat, 2008-02-23 at 10:12 -0600, Alec Kloss wrote:
>>> All of the heavy lifting is done in the big patch at
>>>
>>> http://setfilepointer.com/pub/arla/20080223-arla.diff
>> [...]
>>> Can anyone from Arla comment on the chances for incorporating these
>>> patches into Arla itself? It'd be nice to have these changes in Arla
>>> itself prior to submitting the port to FreeBSD.
>>>
>> Chances are good. If it looks ok it goes in.
>>
> Looks mostly ok, but I do have some questions.
>
> 1) appl/fs/fs_local.h: would that break `fs nnpfsdeb all`?
>
> 2) cf/try-compile-kernel.m4: why do we need /usr/include? It sounds scary
> given that we may want to compile using random kernel trees. Same goes for
> nnpfs/freebsd/FreeBSD-Makefile. I don't know much about kernel build magic.
>
> 3) cf/bsd-vop-unlock.m4: do we need it? I don't care about older versions of
> FreeBSD than 6.x; traditionally we try to support latest stable OS-release
> plus -CURRENT but maybe that's a bit limiting. Perphaps nnpfs_vfs_unlock
> solves part of the problem?
Just back from FOSDEM, and am 3-4 days behind on e-mail, so will need to
investigate (1) and (2) in a day or two.
If I've done (1) correctly then, in practice, it shouldn't change things at
all, except that on FreeBSD 7.x and higher, it will use the priv(9) interface
to check for privilege rather than suser(9). While there are plans for
further privilege semantic changes, the interface change so far is actually a
syntactic change -- the policy remains the same, but information about the
check is managed differently, hence the change to the interface. This is a
precursor to more fine-grained privileges in the kernel.
With respect to (2), I need to look at the details, but I believe this has to
do with the fact that nnpfs is relying on generated files that may not be
present in a kernel source tree. The more right fix may be to force
generation of the files (if we can) in the nnpfs build, as we already do for
vnode_if.h, but I'll have to look in more detail.
With respect to (3) -- that has to do with support for 8-CURRENT, not pre-6.x.
It looks like the VFS folks are in the middle of dropping unnecessary thread
arguments from various locking interfaces in VFS, including
lock/unlock/assert/etc (these will now all be curthread implicitly). I just
saw a couple more such changes trickle in today, so I'll probably have some
more patches, sadly.
Robert N M Watson
Computer Laboratory
University of Cambridge
_______________________________________________
Arla-drinkers mailing list
Arla-drinkers@stacken.kth.se
https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers
