[4078] in arla-drinkers
Re: Simple patch for pts.c
daemon@ATHENA.MIT.EDU (Jeffrey Hutzelman)
Wed Nov 15 18:40:29 2006
From arla-drinkers-bounces@stacken.kth.se Wed Nov 15 23:40:29 2006
Return-Path: <arla-drinkers-bounces@stacken.kth.se>
Delivered-To: arla-drinkers-mtg@bloom-picayune.mit.edu
Received: (qmail 1264 invoked from network); 15 Nov 2006 23:40:29 -0000
Received: from mx3.kth.se (130.237.48.97)
by charon.mit.edu with SMTP; 15 Nov 2006 23:40:29 -0000
Received: from localhost (localhost.localdomain [127.0.0.1])
by mx3.kth.se (Postfix) with ESMTP id 8A91D1407AA;
Thu, 16 Nov 2006 00:40:27 +0100 (CET)
Received: from mx3.kth.se ([127.0.0.1])
by localhost (mx3.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP
id 01859-01-6; Thu, 16 Nov 2006 00:40:25 +0100 (CET)
Received: from tapas.stacken.kth.se (tapas.stacken.kth.se [130.237.234.140])
by mx3.kth.se (Postfix) with ESMTP id A725C140985;
Thu, 16 Nov 2006 00:40:21 +0100 (CET)
Received: from tapas.stacken.kth.se (localhost [127.0.0.1])
by tapas.stacken.kth.se (Postfix) with ESMTP id E91B6534FE;
Thu, 16 Nov 2006 00:40:20 +0100 (CET)
X-Original-To: arla-drinkers@tapas.stacken.kth.se
Delivered-To: arla-drinkers@tapas.stacken.kth.se
Received: from brev.stacken.kth.se (brev.stacken.kth.se [130.237.234.84])
by tapas.stacken.kth.se (Postfix) with ESMTP id 73A69534FE
for <arla-drinkers@tapas.stacken.kth.se>;
Thu, 16 Nov 2006 00:40:19 +0100 (CET)
Received: from mx1.kth.se (mx1.kth.se [130.237.32.140])
by brev.stacken.kth.se (8.12.10/8.12.10) with ESMTP id kAFNeIea002624
for <arla-drinkers@stacken.kth.se>;
Thu, 16 Nov 2006 00:40:18 +0100 (MET)
Received: from localhost (localhost.localdomain [127.0.0.1])
by mx1.kth.se (Postfix) with ESMTP id 9B6DE141177
for <arla-drinkers@stacken.kth.se>;
Thu, 16 Nov 2006 00:40:18 +0100 (CET)
Received: from mx1.kth.se ([127.0.0.1])
by localhost (mx1.kth.se [127.0.0.1]) (amavisd-new,
port 10024) with LMTP
id 21007-01-80 for <arla-drinkers@stacken.kth.se>;
Thu, 16 Nov 2006 00:40:15 +0100 (CET)
Received: from chokecherry.srv.cs.cmu.edu (CHOKECHERRY.SRV.CS.CMU.EDU
[128.2.185.41]) by mx1.kth.se (Postfix) with ESMTP id 19D4D1406FD
for <arla-drinkers@stacken.kth.se>;
Thu, 16 Nov 2006 00:40:14 +0100 (CET)
Received: from SIRIUS.FAC.CS.CMU.EDU (SIRIUS.FAC.CS.CMU.EDU [128.2.209.170])
(authenticated bits=0)
by chokecherry.srv.cs.cmu.edu (8.13.6/8.13.6) with ESMTP id
kAFNe3fj002967
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
Wed, 15 Nov 2006 18:40:08 -0500 (EST)
Date: Wed, 15 Nov 2006 18:40:03 -0500
From: Jeffrey Hutzelman <jhutz@cmu.edu>
To: Tomas Olsson <tol@it.su.se>, Rasmus Kaj <kaj@kth.se>
Subject: Re: Simple patch for pts.c
Message-ID: <D33D3228511FF65F48308BF2@sirius.fac.cs.cmu.edu>
In-Reply-To: <lsrzmazocsv.fsf@kashyyyk.ite.kth.se>
References: <rqcac306v6u.fsf@kashyyyk.ite.kth.se>
<lsrzmazocsv.fsf@kashyyyk.ite.kth.se>
Originator-Info: login-token=Mulberry:01ewmePeVxE7HHVBa+rofOrBJ71WgCPRfofsyisYk=;
token_authority=postmaster@andrew.cmu.edu
X-Mailer: Mulberry/3.1.6 (Linux/x86)
MIME-Version: 1.0
Content-Disposition: inline
X-Virus-Scanned: by amavisd-new at kth.se
X-Spam-Status: No, hits=-4.9 tagged_above=-200.0 required=5.0 tests=BAYES_00
X-Spam-Level:
Cc: Jeffrey Hutzelman <jhutz@cmu.edu>, arla-drinkers@stacken.kth.se
X-BeenThere: arla-drinkers@stacken.kth.se
X-Mailman-Version: 2.1.6
Precedence: list
List-Id: Arla discussions <arla-drinkers.stacken.kth.se>
List-Unsubscribe: <https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers>,
<mailto:arla-drinkers-request@stacken.kth.se?subject=unsubscribe>
List-Archive: <http://lists.stacken.kth.se/pipermail/arla-drinkers>
List-Post: <mailto:arla-drinkers@stacken.kth.se>
List-Help: <mailto:arla-drinkers-request@stacken.kth.se?subject=help>
List-Subscribe: <https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers>,
<mailto:arla-drinkers-request@stacken.kth.se?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: arla-drinkers-bounces@stacken.kth.se
Errors-To: arla-drinkers-bounces@stacken.kth.se
X-Virus-Scanned: by amavisd-new at kth.se
On Friday, November 10, 2006 10:45:20 AM +0100 Tomas Olsson <tol@it.su.se>
wrote:
> Rasmus Kaj <kaj@kth.se> writes:
>> In appl/pts/pts.c, the chown_cmd function, there is a mistake in
>> argument ordering, so pts chown fail.
>>
>> There is a patch in /afs/kth.se/home/k/a/kaj/Public/patch-ptc.c
>>
> Thanks. The original mistake was most likely in that this is the only
> place where the host argument was added after 'cell', so I'd prefer just
> reordering the command's arguments for consistency. Would that cause any
> problems (like widely deployed arla-dependent scripts for example)?
>
> It would also make it slightly less different from the OpenAFS version,
> which is good.
I'm not sure I follow this. OpenAFS doesn't have a -host argument to pts
chown, or any other pts subcommand. Maximal compatibility with OpenAFS
would require putting any new arguments last, and preferably requiring that
the corresponding switches be given explicitly.
Of course, to my knowledge, Transarc, IBM, and the OpenAFS project have
always admonished AFS users to use explict, fully-spelled-out switches in
things like scripts, and save the abbreviations for manually-typed commands.
-- Jeff
_______________________________________________
Arla-drinkers mailing list
Arla-drinkers@stacken.kth.se
https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers
