[4067] in arla-drinkers
Re: Simple patch for pts.c
daemon@ATHENA.MIT.EDU (Tomas Olsson)
Fri Nov 10 04:45:35 2006
From arla-drinkers-bounces@stacken.kth.se Fri Nov 10 09:45:35 2006
Return-Path: <arla-drinkers-bounces@stacken.kth.se>
Delivered-To: arla-drinkers-mtg@bloom-picayune.mit.edu
Received: (qmail 16012 invoked from network); 10 Nov 2006 09:45:34 -0000
Received: from mx3.kth.se (130.237.48.97)
by charon.mit.edu with SMTP; 10 Nov 2006 09:45:34 -0000
Received: from localhost (localhost.localdomain [127.0.0.1])
by mx3.kth.se (Postfix) with ESMTP id 86F76140EF1;
Fri, 10 Nov 2006 10:45:32 +0100 (CET)
Received: from mx3.kth.se ([127.0.0.1])
by localhost (mx3.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP
id 05299-01-12; Fri, 10 Nov 2006 10:45:30 +0100 (CET)
Received: from tapas.stacken.kth.se (tapas.stacken.kth.se [130.237.234.140])
by mx3.kth.se (Postfix) with ESMTP id 2BDD5140B93;
Fri, 10 Nov 2006 10:45:25 +0100 (CET)
Received: from tapas.stacken.kth.se (localhost [127.0.0.1])
by tapas.stacken.kth.se (Postfix) with ESMTP id 88A2853511;
Fri, 10 Nov 2006 10:45:25 +0100 (CET)
X-Original-To: arla-drinkers@tapas.stacken.kth.se
Delivered-To: arla-drinkers@tapas.stacken.kth.se
Received: from brev.stacken.kth.se (brev.stacken.kth.se [130.237.234.84])
by tapas.stacken.kth.se (Postfix) with ESMTP id C015F53511
for <arla-drinkers@tapas.stacken.kth.se>;
Fri, 10 Nov 2006 10:45:23 +0100 (CET)
Received: from mx2.kth.se (mx2.kth.se [130.237.48.98])
by brev.stacken.kth.se (8.12.10/8.12.10) with ESMTP id kAA9jNtk007910
for <arla-drinkers@stacken.kth.se>;
Fri, 10 Nov 2006 10:45:23 +0100 (MET)
Received: from localhost (localhost.localdomain [127.0.0.1])
by mx2.kth.se (Postfix) with ESMTP id 24F84140BFF;
Fri, 10 Nov 2006 10:45:23 +0100 (CET)
Received: from mx2.kth.se ([127.0.0.1])
by localhost (mx2.kth.se [127.0.0.1]) (amavisd-new,
port 10024) with LMTP
id 18465-01-29; Fri, 10 Nov 2006 10:45:20 +0100 (CET)
Received: from kashyyyk.ite.kth.se (kashyyyk.ite.kth.se [130.237.31.35])
by mx2.kth.se (Postfix) with ESMTP id A1C9D140749;
Fri, 10 Nov 2006 10:45:20 +0100 (CET)
Received: by kashyyyk.ite.kth.se (Postfix, from userid 18404)
id 7E6B59600FA; Fri, 10 Nov 2006 10:45:20 +0100 (CET)
From: Tomas Olsson <tol@it.su.se>
To: Rasmus Kaj <kaj@kth.se>
Subject: Re: Simple patch for pts.c
References: <rqcac306v6u.fsf@kashyyyk.ite.kth.se>
Date: 10 Nov 2006 10:45:20 +0100
In-Reply-To: <rqcac306v6u.fsf@kashyyyk.ite.kth.se>
Message-ID: <lsrzmazocsv.fsf@kashyyyk.ite.kth.se>
Lines: 15
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
X-Virus-Scanned: by amavisd-new at kth.se
X-Spam-Status: No, hits=-4.9 tagged_above=-200.0 required=5.0 tests=BAYES_00
X-Spam-Level:
Cc: arla-drinkers@stacken.kth.se
X-BeenThere: arla-drinkers@stacken.kth.se
X-Mailman-Version: 2.1.6
Precedence: list
List-Id: Arla discussions <arla-drinkers.stacken.kth.se>
List-Unsubscribe: <https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers>,
<mailto:arla-drinkers-request@stacken.kth.se?subject=unsubscribe>
List-Archive: <http://lists.stacken.kth.se/pipermail/arla-drinkers>
List-Post: <mailto:arla-drinkers@stacken.kth.se>
List-Help: <mailto:arla-drinkers-request@stacken.kth.se?subject=help>
List-Subscribe: <https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers>,
<mailto:arla-drinkers-request@stacken.kth.se?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: arla-drinkers-bounces@stacken.kth.se
Errors-To: arla-drinkers-bounces@stacken.kth.se
X-Virus-Scanned: by amavisd-new at kth.se
Rasmus Kaj <kaj@kth.se> writes:
> In appl/pts/pts.c, the chown_cmd function, there is a mistake in
> argument ordering, so pts chown fail.
>
> There is a patch in /afs/kth.se/home/k/a/kaj/Public/patch-ptc.c
>
Thanks. The original mistake was most likely in that this is the only place
where the host argument was added after 'cell', so I'd prefer just
reordering the command's arguments for consistency. Would that cause any
problems (like widely deployed arla-dependent scripts for example)?
It would also make it slightly less different from the OpenAFS version,
which is good.
/t
_______________________________________________
Arla-drinkers mailing list
Arla-drinkers@stacken.kth.se
https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers
