[4001] in arla-drinkers

home help back first fref pref prev next nref lref last post

Re: hacks to get 0.44pre going on netbsd-4

daemon@ATHENA.MIT.EDU (Jonathan A. Kollasch)
Thu Aug 24 10:21:05 2006

From arla-drinkers-bounces@stacken.kth.se Thu Aug 24 14:21:05 2006
Return-Path: <arla-drinkers-bounces@stacken.kth.se>
Delivered-To: arla-drinkers-mtg@bloom-picayune.mit.edu
Received: (qmail 11508 invoked from network); 24 Aug 2006 14:21:04 -0000
Received: from mx1.kth.se (130.237.32.140)
  by charon.mit.edu with SMTP; 24 Aug 2006 14:21:04 -0000
Received: from localhost (localhost.localdomain [127.0.0.1])
	by mx1.kth.se (Postfix) with ESMTP id 786A114511C;
	Thu, 24 Aug 2006 16:21:02 +0200 (CEST)
Received: from mx1.kth.se ([127.0.0.1])
 by localhost (mx1.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP
 id 21825-01-6; Thu, 24 Aug 2006 16:21:00 +0200 (CEST)
Received: from tapas.stacken.kth.se (tapas.stacken.kth.se [130.237.234.140])
	by mx1.kth.se (Postfix) with ESMTP id 31524140E71;
	Thu, 24 Aug 2006 16:21:00 +0200 (CEST)
Received: from tapas.stacken.kth.se (localhost [127.0.0.1])
	by tapas.stacken.kth.se (Postfix) with ESMTP id E6C17534FC;
	Thu, 24 Aug 2006 16:20:59 +0200 (CEST)
X-Original-To: arla-drinkers@tapas.stacken.kth.se
Delivered-To: arla-drinkers@tapas.stacken.kth.se
Received: from brev.stacken.kth.se (brev.stacken.kth.se [130.237.234.84])
	by tapas.stacken.kth.se (Postfix) with ESMTP id 6CDFB534FC
	for <arla-drinkers@tapas.stacken.kth.se>;
	Thu, 24 Aug 2006 16:20:58 +0200 (CEST)
Received: from mx3.kth.se (mx3.kth.se [130.237.48.97])
	by brev.stacken.kth.se (8.12.10/8.12.10) with ESMTP id k7OEKvxq027804
	for <arla-drinkers@stacken.kth.se>;
	Thu, 24 Aug 2006 16:20:57 +0200 (MET DST)
Received: from localhost (localhost.localdomain [127.0.0.1])
	by mx3.kth.se (Postfix) with ESMTP id F1F9B14327A
	for <arla-drinkers@stacken.kth.se>;
	Thu, 24 Aug 2006 16:20:56 +0200 (CEST)
Received: from mx3.kth.se ([127.0.0.1])
	by localhost (mx3.kth.se [127.0.0.1]) (amavisd-new,
	port 10024) with LMTP
	id 10526-01-99 for <arla-drinkers@stacken.kth.se>;
	Thu, 24 Aug 2006 16:20:55 +0200 (CEST)
Received: from mail.kollasch.net (unknown [IPv6:2002:a867:36dd:1::19])
	by mx3.kth.se (Postfix) with ESMTP id A0DC9143130
	for <arla-drinkers@stacken.kth.se>;
	Thu, 24 Aug 2006 16:20:54 +0200 (CEST)
Received: from kirkkit.kollasch.net (kirkkit.kollasch.net
	[IPv6:2002:a867:36dd:1:2b0:d0ff:fec8:589c])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.kollasch.net (Postfix) with ESMTP id 3DDFB1738A;
	Thu, 24 Aug 2006 09:20:51 -0500 (CDT)
Date: Thu, 24 Aug 2006 09:20:50 -0500
From: "Jonathan A. Kollasch" <jakllsch@kollasch.net>
To: Tomas Olsson <tol@it.su.se>
Subject: Re: hacks to get 0.44pre going on netbsd-4
Message-ID: <20060824142050.GJ4568@kirkkit.kollasch.net>
References: <20060819220659.GG4568@kirkkit.kollasch.net>
	<lsrmz9xaub8.fsf@kashyyyk.ite.kth.se>
Mime-Version: 1.0
In-Reply-To: <lsrmz9xaub8.fsf@kashyyyk.ite.kth.se>
User-Agent: Mutt/1.5.11
X-Virus-Scanned: by amavisd-new at kth.se
X-Spam-Status: No, hits=-4.9 tagged_above=-200.0 required=5.0 tests=BAYES_00
X-Spam-Level: 
Cc: arla-drinkers@stacken.kth.se
X-BeenThere: arla-drinkers@stacken.kth.se
X-Mailman-Version: 2.1.6
Precedence: list
List-Id: Arla discussions <arla-drinkers.stacken.kth.se>
List-Unsubscribe: <https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers>, 
	<mailto:arla-drinkers-request@stacken.kth.se?subject=unsubscribe>
List-Archive: <http://lists.stacken.kth.se/pipermail/arla-drinkers>
List-Post: <mailto:arla-drinkers@stacken.kth.se>
List-Help: <mailto:arla-drinkers-request@stacken.kth.se?subject=help>
List-Subscribe: <https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers>, 
	<mailto:arla-drinkers-request@stacken.kth.se?subject=subscribe>
Content-Type: multipart/mixed; boundary="===============0098635589=="
Sender: arla-drinkers-bounces@stacken.kth.se
Errors-To: arla-drinkers-bounces@stacken.kth.se
X-Virus-Scanned: by amavisd-new at kth.se


--===============0098635589==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="UK1lfQXsnwKrySH9"
Content-Disposition: inline


--UK1lfQXsnwKrySH9
Content-Type: multipart/mixed; boundary="IJAclU0AInkryoed"
Content-Disposition: inline


--IJAclU0AInkryoed
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 22, 2006 at 01:22:51PM +0200, Tomas Olsson wrote:
> "Jonathan A. Kollasch" <jakllsch@kollasch.net> writes:
> > I've been happily running 0.44pre on NetBSD 3.99.21
> > for a few months now. Aside from the no-PAGs-under-
> > kauth disaster, it works well.
> >=20
> Great.
>=20
> > Anyway that issue aside, there are a few tweaks
> > needed to get stuff going on -4:
> >
> Do you have usable patches?

I've attached what I've got so far. This only fixes the LKM issues.

How important is adapting arlad to use these new opaque file handles?
Either way I think that would involve touching configure, something
I don't want to figure out how to do.

>=20
> I focus on our block_branch at the moment, haven't looked at netbsd for
> that yet (macos works well, though).  Take a look if you have time.  It's
> all Linux for me right now...

Perhaps I should, the lack of this feature is something I often gripe about.

>=20
> > Is there a plan for implementing PAGs under kauth?
> >
> Well, it should be done, but I haven't heard anything.  The best would be
> if we could get kauth to support PAG's (or similar).  Any ideas?

Kauth is originally a Darwin thing, and it seems Elad took the liberty
to make the NetBSD implementation different enough to be frustrating
for folks needing to support both OSes.  However, this also opens
the possibility that NetBSD could diverge more to support this,
assuming Apple is uninterested; but this would probably mean
more #ifdefs in already somewhat difficult to follow code.
Additionally, any change as large as this would surely not
be allowed into 4.0.

Oh, also, the changes I asked for to get stuff going on -current
caused an undesirable side-effect of breaking PAGs on earlier
NetBSD releases.

Looks like I have some more tasks I could be doing.

	Jonathan Kollasch

--IJAclU0AInkryoed
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch
Content-Transfer-Encoding: quoted-printable

diff -ur /tmp/arla/nnpfs/bsd/nnpfs/nnpfs_vfsops-bsd.h /home/jakllsch/arla/n=
npfs/bsd/nnpfs/nnpfs_vfsops-bsd.h
--- /tmp/arla/nnpfs/bsd/nnpfs/nnpfs_vfsops-bsd.h	2006-06-12 14:42:36.000000=
000 -0500
+++ /home/jakllsch/arla/nnpfs/bsd/nnpfs/nnpfs_vfsops-bsd.h	2006-08-22 10:12=
:32.000000000 -0500
@@ -116,7 +116,11 @@
=20
 int
 nnpfs_vptofh(struct vnode * vp,
-	     struct fid * fhp);
+	     struct fid * fhp,
+#if defined(__NetBSD__) && __NetBSD_Version__ >=3D 399002200 /* 3.99.22 */
+	     size_t * fidsz
+#endif
+	     );
=20
 int
 nnpfs_dead_lookup(struct vop_lookup_args *ap);
diff -ur /tmp/arla/nnpfs/bsd/nnpfs_vfsops-bsd.c /home/jakllsch/arla/nnpfs/b=
sd/nnpfs_vfsops-bsd.c
--- /tmp/arla/nnpfs/bsd/nnpfs_vfsops-bsd.c	2006-06-12 14:39:14.000000000 -0=
500
+++ /home/jakllsch/arla/nnpfs/bsd/nnpfs_vfsops-bsd.c	2006-08-22 10:42:06.00=
0000000 -0500
@@ -284,14 +284,25 @@
=20
 int
 nnpfs_vptofh(struct vnode * vp,
-	   struct fid * fhp)
+	   struct fid * fhp,
+#if defined(__NetBSD__) && __NetBSD_Version__ >=3D 399002200 /* 3.99.22 */
+	   size_t * fidsz
+#endif
+	   )
 {
 #ifdef ARLA_KNFS
     struct nnpfs_node *xn;
     NNPFSDEB(XDEBVFOPS, ("nnpfs_vptofh\n"));
=20
+#if defined(__NetBSD__) && __NetBSD_Version__ >=3D 399002200 /* 3.99.22 */
+    if (*fh_size < 16) {
+	*fh_size =3D 16;
+	return E2BIG;
+    }
+#else
     if (MAXFIDSZ < 16)
 	return EOPNOTSUPP;
+#endif
=20
     xn =3D VNODE_TO_XNODE(vp);
=20
@@ -554,8 +565,6 @@
=20
 #if defined(__DragonFly__)
     error =3D falloc(proc->td_proc, &fp, &index);
-#elif defined(__NetBSD__) && __NetBSD_Version__ >=3D 399001400 /* 3.99.14 =
*/
-    error =3D falloc(proc->l_proc, &fp, &index);
 #else
     error =3D falloc(proc, &fp, &index);
 #endif

--IJAclU0AInkryoed--

--UK1lfQXsnwKrySH9
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (NetBSD)

iD8DBQFE7bXCOjx1ye3hmokRAgd3AJ9hu3D51/hu8r9g44mE+9JAmpzqVACdHoPH
WKfzE115OfvaE/Lr1T2sz1E=
=9yxp
-----END PGP SIGNATURE-----

--UK1lfQXsnwKrySH9--

--===============0098635589==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Arla-drinkers mailing list
Arla-drinkers@stacken.kth.se
https://lists.stacken.kth.se/mailman/listinfo/arla-drinkers

--===============0098635589==--

home help back first fref pref prev next nref lref last post