[393] in arla-drinkers

home help back first fref pref prev next nref lref last post

rename bug in arla

daemon@ATHENA.MIT.EDU (Chuck Lever)
Fri Nov 13 13:16:56 1998

From owner-arla-drinkers@stacken.kth.se Fri Nov 13 18:16:55 1998
Return-Path: <owner-arla-drinkers@stacken.kth.se>
Delivered-To: arla-drinkers-mtg@bloom-picayune.mit.edu
Received: (qmail 14600 invoked from network); 13 Nov 1998 18:16:55 -0000
Received: from unknown (HELO sundance.stacken.kth.se) (130.237.234.41)
  by bloom-picayune.mit.edu with SMTP; 13 Nov 1998 18:16:55 -0000
Received: (from majordom@localhost)
	by sundance.stacken.kth.se (8.8.8/8.8.8) id TAA26028
	for arla-drinkers-list; Fri, 13 Nov 1998 19:11:29 +0100 (MET)
Received: from netscape.com (h-205-217-237-46.netscape.com [205.217.237.46])
	by sundance.stacken.kth.se (8.8.8/8.8.8) with ESMTP id TAA26024
	for <arla-drinkers@stacken.kth.se>; Fri, 13 Nov 1998 19:11:24 +0100 (MET)
Received: from dredd.mcom.com (dredd.mcom.com [205.217.237.54])
	by netscape.com (8.8.5/8.8.5) with ESMTP id KAA24881
	for <arla-drinkers@stacken.kth.se>; Fri, 13 Nov 1998 10:10:52 -0800 (PST)
Received: from netscape.com ([206.222.244.179]) by
          dredd.mcom.com (Netscape Messaging Server 4.0) with ESMTP id
          F2DH5Y01.3K4 for <arla-drinkers@stacken.kth.se>; Fri, 13 Nov
          1998 10:10:46 -0800 
Message-ID: <364C75E8.DA9B363E@netscape.com>
Date: Fri, 13 Nov 1998 13:09:44 -0500
From: Chuck Lever <chuckl@netscape.com>
Organization: Netscape Communications Corporation
X-Mailer: Mozilla 4.5 [en]C-NSCP  (WinNT; U)
X-Accept-Language: en
MIME-Version: 1.0
To: arla-drinkers@stacken.kth.se
Subject: rename bug in arla
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=sha1; boundary="------------msFF6793C35D8545486C23AF77"
Sender: owner-arla-drinkers@stacken.kth.se
Precedence: bulk

This is a cryptographically signed message in MIME format.

--------------msFF6793C35D8545486C23AF77
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

i'm not on arla-drinkers, so please reply to me directly... thanks!

i'm a new arla user.  i've installed arla on Linux 2.1.126, and found it
to be faster and better architected than the AFS client i've been
accustomed to on other systems.

however, i found a logic bug in arlad's rename operation.  in
arlad/inter.c, the logic first creates the entry for the new name in the
cached copy of the new directory, then deletes the old one.  the problem
occurs if an entry with the new name already exists.  in this case,
rename should delete that entry first; otherwise two entries with same
name and FID appear in the cached copy of the new directory (which is
what happens today).  this can happen repeatedly, resulting in many
entries in the same directory with the same name and FID.

note that the arla client uses an RPC to tell the server to make the
same change, so the contents of the server's copy of the new directory
are correct since the server ostensibly knows how to do this right.  if
you clear arla's cache and restart it, the directory corruption
disappears because the directory contents are fetched from the server's
correct copy.  other clients will also fetch the server copy, and they
also see correct directory contents.

i don't have a patch yet, because i want to check how some other file
systems handle this case; rename is notoriously difficult to implement. 
i also wanted to check with you to see that this problem hasn't already
been addressed in arla.  please reply and let me know -- if it hasn't
been addressed, i can provide a patch.
--------------msFF6793C35D8545486C23AF77
Content-Type: application/x-pkcs7-signature; name="smime.p7s"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="smime.p7s"
Content-Description: S/MIME Cryptographic Signature

MIIEyAYJKoZIhvcNAQcCoIIEuTCCBLUCAQExCzAJBgUrDgMCGgUAMAsGCSqGSIb3DQEHAaCC
ArkwggK1MIICHqADAgECAgIZGTANBgkqhkiG9w0BAQQFADB3MQswCQYDVQQGEwJVUzEsMCoG
A1UEChMjTmV0c2NhcGUgQ29tbXVuaWNhdGlvbnMgQ29ycG9yYXRpb24xHDAaBgNVBAsTE0lu
Zm9ybWF0aW9uIFN5c3RlbXMxHDAaBgNVBAMTE3Jvb3RjYS5uZXRzY2FwZS5jb20wHhcNOTgx
MDEzMjIzNzU4WhcNOTkwNDExMjIzNzU4WjCBkDELMAkGA1UEBhMCVVMxJjAkBgNVBAoTHU5l
dHNjYXBlIENvbW11bmljYXRpb25zIENvcnAuMR0wGwYDVQQDExRDaGFybGVzIEUuIExldmVy
IElJSTEiMCAGCSqGSIb3DQEJARYTY2h1Y2tsQG5ldHNjYXBlLmNvbTEWMBQGCgmSJomT8ixk
AQETBmNodWNrbDCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEA3ib1JVx6ZhJAYFUiLJGv
TL+tlhxKuezQhJnztZg1fXOgfw0fJxWYLaMS2mJ1ImmA7tbT++myjDEZVHdszU9YllqG7D2Y
3khIH1/2Zx0AbXPSyxTU7afXCOa+0EoBrPkNCkYdiU9OpcsEJtTP0ZpzPd+7/5di1NQisxtz
3Y/sx10CAwEAAaM2MDQwEQYJYIZIAYb4QgEBBAQDAgCgMB8GA1UdIwQYMBaAFPzgVOgH8ZXe
OveZxq76FQxuxC6SMA0GCSqGSIb3DQEBBAUAA4GBADhze0+3pAOJk/XpHivAnxdUv6cmJWRs
9cAseThqjhgIFxdVuojVlUoc1qYM9uI/jzHVu/q1CkdLiACtlcZHCZW6qwUHxGxIanktsgyt
f1VJpeC9lQlqW+VAX4sWlqp+Q3zE2OINHCQVbDdrwFPiYO6E9ddTMgA4JkBUdjJ1ARt+MYIB
1zCCAdMCAQEwfTB3MQswCQYDVQQGEwJVUzEsMCoGA1UEChMjTmV0c2NhcGUgQ29tbXVuaWNh
dGlvbnMgQ29ycG9yYXRpb24xHDAaBgNVBAsTE0luZm9ybWF0aW9uIFN5c3RlbXMxHDAaBgNV
BAMTE3Jvb3RjYS5uZXRzY2FwZS5jb20CAhkZMAkGBSsOAwIaBQCggbEwGAYJKoZIhvcNAQkD
MQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNOTgxMTEzMTgwOTQ0WjAjBgkqhkiG9w0B
CQQxFgQUQ7KeDmHB9AD81Yi2U9QQ5EhFNXgwUgYJKoZIhvcNAQkPMUUwQzAKBggqhkiG9w0D
BzAOBggqhkiG9w0DAgICAIAwBwYFKw4DAgcwDQYIKoZIhvcNAwICAUAwDQYIKoZIhvcNAwIC
ASgwDQYJKoZIhvcNAQEBBQAEgYBS6cnyoQYe0p+VzTnCn0ojTkYTgiFW1Jv1rndHQjGt6yJt
o05tpuh7FzE751UBXeSI1NxDdd1d4QHwl3r6u9ZT4Q+Lvxm1E/h02msXEy1mt1lCZDvPU/j6
T+YGTzk8EeCxSZF1bjjyyKO+9Z+MDLyFsO6Kic4yMZnh34zbzy87dA==
--------------msFF6793C35D8545486C23AF77--


home help back first fref pref prev next nref lref last post