[334] in arla-drinkers
Re: get_unused_fd()
daemon@ATHENA.MIT.EDU (Magnus Ahltorp)
Wed Oct 21 12:00:08 1998
From owner-arla-drinkers@stacken.kth.se Wed Oct 21 16:00:07 1998
Return-Path: <owner-arla-drinkers@stacken.kth.se>
Delivered-To: arla-drinkers-mtg@bloom-picayune.mit.edu
Received: (qmail 5782 invoked from network); 21 Oct 1998 16:00:05 -0000
Received: from unknown (HELO sundance.stacken.kth.se) (130.237.234.41)
by bloom-picayune.mit.edu with SMTP; 21 Oct 1998 16:00:05 -0000
Received: (from majordom@localhost)
by sundance.stacken.kth.se (8.8.8/8.8.8) id RAA10101
for arla-drinkers-list; Wed, 21 Oct 1998 17:53:58 +0200 (MET DST)
Received: (from map@localhost)
by sundance.stacken.kth.se (8.8.8/8.8.8) id RAA10087;
Wed, 21 Oct 1998 17:53:39 +0200 (MET DST)
To: Alexander Viro <viro@math.psu.edu>
Cc: Magnus Ahltorp <map@stacken.kth.se>,
Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.rutgers.edu,
arla-drinkers@stacken.kth.se
Subject: Re: get_unused_fd()
References: <Pine.SOL.3.95.981021144332.942D-100000@albert.math.psu.edu>
From: Magnus Ahltorp <map@stacken.kth.se>
Date: 21 Oct 1998 17:53:18 +0200
In-Reply-To: Alexander Viro's message of Wed, 21 Oct 1998 14:54:38 -0400 (EDT)
Message-ID: <lv14ssxap3l.fsf@sundance.stacken.kth.se>
Lines: 22
X-Mailer: Gnus v5.3/Emacs 19.34
Sender: owner-arla-drinkers@stacken.kth.se
Precedence: bulk
> It would be nice if you'ld show how _exactly_ you are going to use
> get_empty_filp(). There are several reasons to split inuse_filp into
> several lists (for superblock; for tty; for protocol family). That would
> simplify dquot.c and some nasty stuff in tty_io.c. Right now I'm
> experimenting with such patch and if everything will go OK I'm going to
> submit it to Linus in a day or two. We got waaay too many leaks/dangling
> pointers/etc. in the code that deals with struct file's. I'm trying to go
> through this stuff and massage it into something more coherent. And IMHO
> get_empty_filp() belongs to guts of that stuff.
First, do you have any objections against the export of the
get_unused_fd() call?
Regarding the get_empty_filp(), I'm simply using it for allocating a
struct file. The struct file gets filled in, and fd_install (this
symbol is exported, wow) is then used to put things where they should
be.
/Magnus
map@stacken.kth.se
